Issue 23653044: Move prefs::kLastPolicyStatisticsUpdate to the policy component.

Issue 23653044: Move prefs::kLastPolicyStatisticsUpdate to the policy component. (Closed)

Created:
7 years, 3 months ago by dconnelly

Modified:
7 years, 3 months ago

Reviewers:
Joao da Silva

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move prefs::kLastPolicyStatisticsUpdate to the policy component. This change adds components/policy/core/common/pref_names.(h|cc), which holds alls policy-specific pref names. This removes DEPS violations from the PolicyStatisticsCollector. BUG=271392 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224111

Patch Set 1 #

Patch Set 2 : various movings around and export #

Total comments: 2

Patch Set 3 : add TODO #

Patch Set 4 : rebase #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -19 lines)			Patch
M	chrome/browser/policy/DEPS	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/policy/policy_statistics_collector.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/policy_statistics_collector_unittest.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1 2 3	1 chunk	+0 lines, -4 lines	0 comments	Download
M	components/policy.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	components/policy/core/common/policy_pref_names.h	View	1 2	1 chunk	+21 lines, -0 lines	0 comments	Download
A	components/policy/core/common/policy_pref_names.cc	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

lgtm https://codereview.chromium.org/23653044/diff/3001/components/policy/core/common/policy_pref_names.h File components/policy/core/common/policy_pref_names.h (right): https://codereview.chromium.org/23653044/diff/3001/components/policy/core/common/policy_pref_names.h#newcode14 components/policy/core/common/policy_pref_names.h:14: POLICY_EXPORT extern const char kLastPolicyStatisticsUpdate[]; Leave a TODO ...

7 years, 3 months ago (2013-09-18 13:36:13 UTC) #2

dconnelly

https://codereview.chromium.org/23653044/diff/3001/components/policy/core/common/policy_pref_names.h File components/policy/core/common/policy_pref_names.h (right): https://codereview.chromium.org/23653044/diff/3001/components/policy/core/common/policy_pref_names.h#newcode14 components/policy/core/common/policy_pref_names.h:14: POLICY_EXPORT extern const char kLastPolicyStatisticsUpdate[]; On 2013/09/18 13:36:13, Joao ...

7 years, 3 months ago (2013-09-19 09:12:55 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/23653044/13001

7 years, 3 months ago (2013-09-19 09:33:25 UTC) #4

Message was sent while issue was closed.

Change committed as 224111

Expand Messages | Collapse Messages