Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 23653025: Change PrefService.ReadError histogram to sample success case. (Closed)

Created:
7 years, 3 months ago by Mattias Nissler (ping if slow)
Modified:
7 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Visibility:
Public.

Description

Change PrefService.ReadError histogram to sample success case. The previous data didn't give us any indication of the actual error rate but just the error distribution. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222023

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/prefs/chrome_pref_service_factory.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mattias Nissler (ping if slow)
Please review.
7 years, 3 months ago (2013-09-09 12:19:10 UTC) #1
Bernhard Bauer
LGTM
7 years, 3 months ago (2013-09-09 12:20:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/23653025/1
7 years, 3 months ago (2013-09-09 12:28:06 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 14:16:50 UTC) #4
Message was sent while issue was closed.
Change committed as 222023

Powered by Google App Engine
This is Rietveld 408576698