Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 23653018: Switch out random number generator for tests, benches, samples. (Closed)

Created:
7 years, 3 months ago by jvanverth1
Modified:
7 years, 3 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Switch out random number generator for tests, benches, samples. This change makes tests, benches and samples use the new SkMWCRandom PRNG. GMs will be saved for another time, as they'll require rebaselining. Committed: http://code.google.com/p/skia/source/detail?r=11136

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Revert gm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -88 lines) Patch
M bench/AAClipBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/BicubicBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/BitmapBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/BitmapRectBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/BlurBench.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M bench/ChecksumBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/GrMemoryPoolBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/HairlinePathBench.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M bench/LineBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/MathBench.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M bench/MatrixBench.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M bench/MatrixConvolutionBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/MorphologyBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/PathBench.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M bench/PathIterBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/PictureRecordBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/RectBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/RegionBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/RegionContainBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/ScalarBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/ShaderMaskBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/SortBench.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M bench/TextBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/VertBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleAnimBlur.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleApp.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleClip.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M samplecode/SampleCull.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleEmptyPath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleFontCache.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleHairCurves.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M samplecode/SamplePathEffects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SamplePicture.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SamplePoints.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleRotateCircles.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleSlides.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleStrokePath.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleText.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleTextAlpha.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleVertices.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/BitmapGetColorTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/MathTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/MatrixTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/MipMapTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PaintTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jvanverth1
You'll notice that some GM files look like they've changed. That's git or cl being ...
7 years, 3 months ago (2013-09-05 14:27:40 UTC) #1
bsalomon
lgtm
7 years, 3 months ago (2013-09-05 14:33:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/23653018/1
7 years, 3 months ago (2013-09-06 18:10:13 UTC) #3
commit-bot: I haz the power
Failed to apply patch for gm/circles.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 3 months ago (2013-09-06 18:10:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/23653018/8001
7 years, 3 months ago (2013-09-06 18:53:54 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 19:05:34 UTC) #6
Message was sent while issue was closed.
Change committed as 11136

Powered by Google App Engine
This is Rietveld 408576698