QUIC/1+SPYD/3 => QUIC

QUIC/1+SPYD/3 => QUIC

Rename enum identifiers:
* s/kProtoQUIC1SPDY3/kProtoQUIC/ in enum NextProto;
* s/CONNECTION_INFO_QUIC1_SPDY3/CONNECTION_INFO_QUIC/ in enum HttpResponseInfo.

This CL means no functional change.  A follow-up CL might change the "quic/1+spdy/3"
string literal in HttpResponseInfo::ConnectionInfoToString() and
SSLClientSocket::NextProtoToString().

Committed: https://crrev.com/401eb9231c325410eadf48595c2e3cb4ca7df076
Cr-Commit-Position: refs/heads/master@{#426816}

[Bence, 2016-09-27 13:12:20]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 13:12:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 13:53:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 13:53:53]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Bence, 2016-09-27 14:05:16]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 14:05:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 15:17:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 15:17:39]

Dry run: This issue passed the CQ dry run.

[Bence, 2016-09-27 16:36:58]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2016-09-27 16:36:59]

Ryan: PTAL.

[Bence, 2016-10-03 19:12:30]

On 2016/09/27 16:36:59, Bence wrote:
> Ryan: PTAL.

Ping.

[Bence, 2016-10-19 18:02:11]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 18:02:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 20:35:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 20:35:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ryan Hamilton, 2016-10-19 23:07:52]

lgtm

https://codereview.chromium.org/2365243004/diff/40001/net/http/http_response_...
File net/http/http_response_info.cc (right):

https://codereview.chromium.org/2365243004/diff/40001/net/http/http_response_...
net/http/http_response_info.cc:463: return "quic/1+spdy/3";
And of course we should fix this once we get consensus on that email thread.

https://codereview.chromium.org/2365243004/diff/40001/net/socket/ssl_client_s...
File net/socket/ssl_client_socket.cc (right):

https://codereview.chromium.org/2365243004/diff/40001/net/socket/ssl_client_s...
net/socket/ssl_client_socket.cc:37: } else if (proto_string == "quic/1+spdy/3")
{
(And here and below).  Weird that we have these strings repeated in multiple
places instead of being kSomething somewhere).

[Bence, 2016-10-20 12:04:46]

The CQ bit was checked by bnc@chromium.org

[Bence, 2016-10-20 12:04:49]

The CQ bit was unchecked by bnc@chromium.org

[Bence, 2016-10-20 12:07:42]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2016-10-20 12:07:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2016-10-20 12:09:59]

The CQ bit was unchecked by bnc@chromium.org

[Bence, 2016-10-20 12:22:40]

Description was changed from

==========
QUIC/1+SPYD/3 => QUIC

Rename enum identifiers:
* s/kProtoQUIC1SPDY3/kProtoQUIC/ in enum NextProto;
* s/CONNECTION_INFO_QUIC1_SPDY3/CONNECTION_INFO_QUIC/ in enum HttpResponseInfo.

Unfortunately "quic/1+spdy/3" string literal in
HttpResponseInfo::ConnectionInfoToString() and
SSLClientSocket::NextProtoToString() etc. cannot be modified, because this
string gets exposed to the web platform, so any change could break websites and
extensions in spectacular ways.
==========

to

==========
QUIC/1+SPYD/3 => QUIC

Rename enum identifiers:
* s/kProtoQUIC1SPDY3/kProtoQUIC/ in enum NextProto;
* s/CONNECTION_INFO_QUIC1_SPDY3/CONNECTION_INFO_QUIC/ in enum HttpResponseInfo.

This CL means to functional change.  A follow-up CL might change the
"quic/1+spdy/3"
string literal in HttpResponseInfo::ConnectionInfoToString() and
SSLClientSocket::NextProtoToString().
==========

[Bence, 2016-10-20 12:22:49]

bnc@chromium.org changed reviewers:
+ rdsmith@chromium.org, xunjieli@chromium.org

[Bence, 2016-10-20 12:22:50]

Helen: PTAL at components/cronet/.
Randy: PTAL at components/domain_reliability/.
Thank you both.

https://codereview.chromium.org/2365243004/diff/40001/net/http/http_response_...
File net/http/http_response_info.cc (right):

https://codereview.chromium.org/2365243004/diff/40001/net/http/http_response_...
net/http/http_response_info.cc:463: return "quic/1+spdy/3";
On 2016/10/19 23:07:52, Ryan Hamilton wrote:
> And of course we should fix this once we get consensus on that email thread.

Acknowledged.

https://codereview.chromium.org/2365243004/diff/40001/net/socket/ssl_client_s...
File net/socket/ssl_client_socket.cc (right):

https://codereview.chromium.org/2365243004/diff/40001/net/socket/ssl_client_s...
net/socket/ssl_client_socket.cc:37: } else if (proto_string == "quic/1+spdy/3")
{
On 2016/10/19 23:07:52, Ryan Hamilton wrote:
> (And here and below).  Weird that we have these strings repeated in multiple
> places instead of being kSomething somewhere).

Indeed.  From e-mail thread consensus it seems like this string will include
QUIC version, so I will create a helper function to generate such string in a
subsequent CL.

[xunjieli, 2016-10-20 13:53:34]

On 2016/10/20 12:22:50, Bence wrote:
> Helen: PTAL at components/cronet/.

LGTM. Out of paranoia, I also kicked off a run on android_cronet_tester in case
some test files also depend on that enum :)

[Randy Smith (Not in Mondays), 2016-10-20 17:13:54]

components/domain_reliability stamp (assuming change of constant makes sense).

[Bence, 2016-10-21 12:52:15]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2016-10-21 12:52:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 13:13:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 13:13:22]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Bence, 2016-10-21 13:53:09]

Description was changed from

==========
QUIC/1+SPYD/3 => QUIC

Rename enum identifiers:
* s/kProtoQUIC1SPDY3/kProtoQUIC/ in enum NextProto;
* s/CONNECTION_INFO_QUIC1_SPDY3/CONNECTION_INFO_QUIC/ in enum HttpResponseInfo.

This CL means to functional change.  A follow-up CL might change the
"quic/1+spdy/3"
string literal in HttpResponseInfo::ConnectionInfoToString() and
SSLClientSocket::NextProtoToString().
==========

to

==========
QUIC/1+SPYD/3 => QUIC

Rename enum identifiers:
* s/kProtoQUIC1SPDY3/kProtoQUIC/ in enum NextProto;
* s/CONNECTION_INFO_QUIC1_SPDY3/CONNECTION_INFO_QUIC/ in enum HttpResponseInfo.

This CL means no functional change.  A follow-up CL might change the
"quic/1+spdy/3"
string literal in HttpResponseInfo::ConnectionInfoToString() and
SSLClientSocket::NextProtoToString().
==========

[Randy Smith (Not in Mondays), 2016-10-21 14:30:36]

Whoops; sorry.  Braino.  LGTM.

[Bence, 2016-10-21 15:44:51]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2016-10-21 15:45:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 16:49:57]

Description was changed from

==========
QUIC/1+SPYD/3 => QUIC

Rename enum identifiers:
* s/kProtoQUIC1SPDY3/kProtoQUIC/ in enum NextProto;
* s/CONNECTION_INFO_QUIC1_SPDY3/CONNECTION_INFO_QUIC/ in enum HttpResponseInfo.

This CL means no functional change.  A follow-up CL might change the
"quic/1+spdy/3"
string literal in HttpResponseInfo::ConnectionInfoToString() and
SSLClientSocket::NextProtoToString().
==========

to

==========
QUIC/1+SPYD/3 => QUIC

Rename enum identifiers:
* s/kProtoQUIC1SPDY3/kProtoQUIC/ in enum NextProto;
* s/CONNECTION_INFO_QUIC1_SPDY3/CONNECTION_INFO_QUIC/ in enum HttpResponseInfo.

This CL means no functional change.  A follow-up CL might change the
"quic/1+spdy/3"
string literal in HttpResponseInfo::ConnectionInfoToString() and
SSLClientSocket::NextProtoToString().
==========

[commit-bot: I haz the power, 2016-10-21 16:49:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 17:05:53]

Description was changed from

==========
QUIC/1+SPYD/3 => QUIC

Rename enum identifiers:
* s/kProtoQUIC1SPDY3/kProtoQUIC/ in enum NextProto;
* s/CONNECTION_INFO_QUIC1_SPDY3/CONNECTION_INFO_QUIC/ in enum HttpResponseInfo.

This CL means no functional change.  A follow-up CL might change the
"quic/1+spdy/3"
string literal in HttpResponseInfo::ConnectionInfoToString() and
SSLClientSocket::NextProtoToString().
==========

to

==========
QUIC/1+SPYD/3 => QUIC

Rename enum identifiers:
* s/kProtoQUIC1SPDY3/kProtoQUIC/ in enum NextProto;
* s/CONNECTION_INFO_QUIC1_SPDY3/CONNECTION_INFO_QUIC/ in enum HttpResponseInfo.

This CL means no functional change.  A follow-up CL might change the
"quic/1+spdy/3"
string literal in HttpResponseInfo::ConnectionInfoToString() and
SSLClientSocket::NextProtoToString().

Committed: https://crrev.com/401eb9231c325410eadf48595c2e3cb4ca7df076
Cr-Commit-Position: refs/heads/master@{#426816}
==========

[commit-bot: I haz the power, 2016-10-21 17:05:55]

Patchset 3 (id:??) landed as
https://crrev.com/401eb9231c325410eadf48595c2e3cb4ca7df076
Cr-Commit-Position: refs/heads/master@{#426816}