Allow user data dir to be specified in the environment.

Allow user data dir to be specified in the environment.

This allows us to address one of the top user-reported problems with
Chrome Remote Desktop on Linux; namely that when users run Chrome
inside their virtual desktop, it simply opens a new window in their
existing Chrome instance (or, worse, if the first run of Chrome is in
their virtual session, then it prevents them running Chrome on the
console).

Once this change hits Stable, we will be able to update our
virtual session start-up scripts to set the environment variable,
letting the user run Chrome on both their console and virtual
desktops. They can then use Chrome Sync to keep bookmarks etc.
synchronized.

BUG=253614
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222160

[Jamie, 2013-08-28 20:54:00]

wez: ptal
cpu: for OWNERS
jschuh: mostly fyi since you consulted on this.

[Wez, 2013-08-28 21:06:41]

lgtm

https://codereview.chromium.org/23651006/diff/1/chrome/app/chrome_main_delega...
File chrome/app/chrome_main_delegate.cc (right):

https://codereview.chromium.org/23651006/diff/1/chrome/app/chrome_main_delega...
chrome/app/chrome_main_delegate.cc:604: user_data_dir =
base::FilePath::FromUTF8Unsafe(user_data_dir_string);
nit: Braces around this, since the condition spans multiple lines, and because
this file seems to always use braces on ifs...

[jschuh, 2013-08-28 21:27:58]

You don't need my review on this, since it doesn't have a security impact.

[Jamie, 2013-08-30 18:04:13]

cpu: Ping.

[cpu_(ooo_6.6-7.5), 2013-09-03 21:06:27]

this is windows code, maybe I misread the description of the CL?

[Jamie, 2013-09-03 21:12:43]

On 2013/09/03 21:06:27, cpu wrote:
> this is windows code, maybe I misread the description of the CL?

It's cross-platform I think. At any rate, it works on Linux, which is the only
platform we need it on (I'd be okay with ifdefs to enforce that if you'd
prefer).

[cpu_(ooo_6.6-7.5), 2013-09-03 21:12:50]

also the delegate only executes on Windows 8.

[cpu_(ooo_6.6-7.5), 2013-09-07 02:17:27]

yes please ifdef.

lgtm with that.

[Jamie, 2013-09-09 20:13:00]

fyi

https://codereview.chromium.org/23651006/diff/1/chrome/app/chrome_main_delega...
File chrome/app/chrome_main_delegate.cc (right):

https://codereview.chromium.org/23651006/diff/1/chrome/app/chrome_main_delega...
chrome/app/chrome_main_delegate.cc:604: user_data_dir =
base::FilePath::FromUTF8Unsafe(user_data_dir_string);
On 2013/08/28 21:06:41, Wez wrote:
> nit: Braces around this, since the condition spans multiple lines, and because
> this file seems to always use braces on ifs...

Done.

[commit-bot: I haz the power, 2013-09-09 20:13:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/23651006/27001

[commit-bot: I haz the power, 2013-09-10 00:51:45]

Change committed as 222160