Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: Source/modules/webmidi/MIDIInput.cpp

Issue 23648006: Web MIDI: tentative sysex check for receiving messages (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webmidi/MIDIInput.cpp
diff --git a/Source/modules/webmidi/MIDIInput.cpp b/Source/modules/webmidi/MIDIInput.cpp
index a5fd6ce552c1301056c82b69187648308dad5f14..e6fefa4b66894201be8c23f98ce91d14c780bbab 100644
--- a/Source/modules/webmidi/MIDIInput.cpp
+++ b/Source/modules/webmidi/MIDIInput.cpp
@@ -30,6 +30,8 @@
#include "config.h"
#include "modules/webmidi/MIDIInput.h"
+
+#include "modules/webmidi/MIDIAccess.h"
#include "modules/webmidi/MIDIMessageEvent.h"
namespace WebCore {
@@ -59,8 +61,8 @@ void MIDIInput::didReceiveMIDIData(unsigned portIndex, const unsigned char* data
unsigned char status = data[i];
unsigned char strippedStatus = status & 0xf0;
- // FIXME: support System Exclusive.
- if (strippedStatus >= 0xf0)
+ // FIXME: integrate sending side filtering and implement more extensive filtering.
+ if (strippedStatus >= 0xf0 && !m_access->sysExEnabled())
break;
// All non System Exclusive messages have a total size of 3 except for Program Change and Channel Pressure.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698