LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector.html - Issue 23648005: Moving clock timeout flakiness guard in test to 20 ms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector.html

Issue 23648005: Moving clock timeout flakiness guard in test to 20 ms (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/mediastream/RTCPeerConnection-stats.html ('k') | LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector.html

diff --git a/LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector.html b/LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector.html

index 0529138a988746fe4d57a399f96ae83ab7ef41c7..3ba2bb62c0f4ab976fa52487aef4983cb5f3de09 100644

--- a/LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector.html

+++ b/LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector.html

@@ -41,7 +41,13 @@ function statsHandler2(status)

shouldBeGreaterThanOrEqual('result.length', '1');

local = result[0].local;

timestamp = local.timestamp;

- shouldBeGreaterThanOrEqual('timestamp', 'startTime');

+ // Windows XP sometimes gives time that appears to go backwards.

+ // This hack will make the tests non-flaky if it never goes backwards

+ // by more than 20 milliseconds.

+ // Up to 10 milliseconds has been observed on XP, 2 milliseconds on Win7.

+ fudgeForXP = 20;

+ timediff = timestamp - startTime + fudgeForXP;

+ shouldBeGreaterThanOrEqual('timediff', '0');

shouldBe('local.stat("type")', '"video"');

finishJSTest();

}