Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 23648005: Moving clock timeout flakiness guard in test to 20 ms (Closed)

Created:
7 years, 3 months ago by hta - Chromium
Modified:
7 years, 3 months ago
Reviewers:
Tommy Widenflycht
CC:
blink-reviews, tommyw+watchlist_chromium.org, eae+blinkwatch, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Moving clock timeout flakiness guard in test to 20 ms Up to 10 ms backwards clock jumps has been seen on XP, 2 ms on Win7. BUG=282620 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157448

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M LayoutTests/fast/mediastream/RTCPeerConnection-stats.html View 1 chunk +3 lines, -2 lines 0 comments Download
M LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector.html View 1 chunk +7 lines, -1 line 0 comments Download
M LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
hta - Chromium
PTAL.
7 years, 3 months ago (2013-09-06 11:28:53 UTC) #1
tommi (sloooow) - chröme
hey hta - sorry, I thought this was a chromium change. I'm sorry but I ...
7 years, 3 months ago (2013-09-06 11:34:28 UTC) #2
Tommy Widenflycht
lgtm
7 years, 3 months ago (2013-09-09 07:24:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hta@chromium.org/23648005/1
7 years, 3 months ago (2013-09-09 07:26:14 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-09 07:35:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hta@chromium.org/23648005/1
7 years, 3 months ago (2013-09-09 09:56:44 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 10:58:14 UTC) #7
Message was sent while issue was closed.
Change committed as 157448

Powered by Google App Engine
This is Rietveld 408576698