Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 23648004: Clean up Android layouts. (Closed)

Created:
7 years, 3 months ago by newt (away)
Modified:
7 years, 3 months ago
Reviewers:
Ted C, Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, jam, garykac+watch_chromium.org, joi+watch-content_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, weitaosu+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org, jochen+watch_chromium.org
Visibility:
Public.

Description

Clean up Android layouts. This replaces the deprecated "fill_parent" with "match_parent", and "dip" with the preferred "dp". Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221542

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -32 lines) Patch
M chrome/android/java/res/layout/js_modal_dialog.xml View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/res/layout/multi_field_time_picker_dialog.xml View 5 chunks +16 lines, -16 lines 0 comments Download
M content/public/android/java/res/layout/two_field_date_picker.xml View 2 chunks +4 lines, -4 lines 0 comments Download
M content/shell/android/browsertests_apk/res/layout/test_activity.xml View 1 chunk +1 line, -1 line 0 comments Download
M remoting/resources/layout/host.xml View 1 chunk +1 line, -1 line 0 comments Download
M remoting/resources/layout/main.xml View 1 chunk +5 lines, -5 lines 0 comments Download
M remoting/resources/layout/pin_dialog.xml View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/android/java/res/layout/autofill_text.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
newt (away)
+tedchoc for chrome/ and content/ +wez for remoting/
7 years, 3 months ago (2013-09-05 02:36:29 UTC) #1
Ted C
lgtm
7 years, 3 months ago (2013-09-05 02:43:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/23648004/1
7 years, 3 months ago (2013-09-05 03:29:20 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=23871
7 years, 3 months ago (2013-09-05 03:42:01 UTC) #4
Wez
lgtm
7 years, 3 months ago (2013-09-05 17:51:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/23648004/1
7 years, 3 months ago (2013-09-05 17:51:41 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 23:30:40 UTC) #7
Message was sent while issue was closed.
Change committed as 221542

Powered by Google App Engine
This is Rietveld 408576698