Issue 23645008: Use a weak pointer to determine if resizer was destroyed by nested Drag calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23645008: Use a weak pointer to determine if resizer was destroyed by nested Drag calls. (Closed)

Created:
7 years, 3 months ago by flackr

Modified:
7 years, 3 months ago

Reviewers:
stevenjb, sky

CC:
chromium-reviews, sadrul, dcheng, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Use a weak pointer to determine if resizer was destroyed by nested Drag calls. BUG=None TEST=*ResizerTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221790

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -45 lines)			Patch
M	ash/wm/dock/docked_window_resizer.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	ash/wm/dock/docked_window_resizer.cc	View	5 chunks	+6 lines, -11 lines	0 comments	Download
M	ash/wm/drag_window_resizer.h	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	ash/wm/drag_window_resizer.cc	View	4 chunks	+5 lines, -13 lines	0 comments	Download
M	ash/wm/panels/panel_window_resizer.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	ash/wm/panels/panel_window_resizer.cc	View	5 chunks	+6 lines, -11 lines	0 comments	Download

Total messages: 4 (0 generated)

flackr

Hey, I remember this destroyed bool pattern coming up in the review of panel_window_resizer and ...

7 years, 3 months ago (2013-09-06 01:52:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/23645008/1

7 years, 3 months ago (2013-09-06 16:34:15 UTC) #3

Message was sent while issue was closed.

Change committed as 221790