Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2364373002: Removed some URL Utility functions & improved unit tests (Closed)

Created:
4 years, 2 months ago by pkl (ping after 24h if needed)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed some URL Utility functions & improved unit tests The removed utility functions are no longer used. The improved unit tests give better coverage to the functions that remain. Committed: https://crrev.com/693f71d7a044b4f2464bf09f4d6e44b77ca1aecc Cr-Commit-Position: refs/heads/master@{#426511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -78 lines) Patch
M ios/chrome/browser/chrome_url_util.h View 2 chunks +0 lines, -13 lines 0 comments Download
M ios/chrome/browser/chrome_url_util.mm View 5 chunks +5 lines, -38 lines 0 comments Download
M ios/chrome/browser/chrome_url_util_unittest.mm View 3 chunks +30 lines, -27 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
pkl (ping after 24h if needed)
4 years, 2 months ago (2016-09-26 15:23:01 UTC) #2
pkl (ping after 24h if needed)
ping
4 years, 2 months ago (2016-09-27 19:45:09 UTC) #3
rohitrao (ping after 24h)
This CL looks like it's doing more than just deleting unused methods. Can you provide ...
4 years, 2 months ago (2016-09-27 19:46:41 UTC) #4
pkl (ping after 24h if needed)
On 2016/09/27 19:46:41, rohitrao wrote: > This CL looks like it's doing more than just ...
4 years, 2 months ago (2016-09-27 20:53:37 UTC) #6
pkl (ping after 24h if needed)
ping
4 years, 2 months ago (2016-10-07 22:05:11 UTC) #7
pkl (ping after 24h if needed)
pinging again... please review.
4 years, 2 months ago (2016-10-18 14:13:32 UTC) #8
rohitrao (ping after 24h)
lgtm
4 years, 2 months ago (2016-10-20 16:32:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364373002/1
4 years, 2 months ago (2016-10-20 16:38:54 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 17:12:51 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:19:24 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/693f71d7a044b4f2464bf09f4d6e44b77ca1aecc
Cr-Commit-Position: refs/heads/master@{#426511}

Powered by Google App Engine
This is Rietveld 408576698