Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 23642004: Switched PostTaskAndReplyRelay to use ThreadTaskRunnerHandle::Get() instead of MessageLoopProxy::cu… (Closed)

Created:
7 years, 3 months ago by alexeypa (please no reviews)
Modified:
7 years, 3 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Switched PostTaskAndReplyRelay to use ThreadTaskRunnerHandle::Get() instead of MessageLoopProxy::current(). This allows PostTaskAndReplyRelay to be used with non-standard implementations of TaskRunner interface. One such example is remoting::PluginThreadTaskRunner that allows to posts tasks to the main thread of Chromoting Host plugin. BUG=281750 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220518

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M base/threading/post_task_and_reply_impl.cc View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
alexeypa (please no reviews)
PTAL.
7 years, 3 months ago (2013-08-29 23:20:59 UTC) #1
jam
On 2013/08/29 23:20:59, alexeypa wrote: > PTAL. i'm not an owner in base
7 years, 3 months ago (2013-08-29 23:31:31 UTC) #2
alexeypa (please no reviews)
On 2013/08/29 23:31:31, jam wrote: > On 2013/08/29 23:20:59, alexeypa wrote: > > PTAL. > ...
7 years, 3 months ago (2013-08-29 23:38:06 UTC) #3
alexeypa (please no reviews)
PTAL.
7 years, 3 months ago (2013-08-29 23:38:19 UTC) #4
jar (doing other things)
7 years, 3 months ago (2013-08-30 02:31:16 UTC) #5
jar (doing other things)
lgtm
7 years, 3 months ago (2013-08-30 02:31:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/23642004/1
7 years, 3 months ago (2013-08-30 02:33:25 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 06:38:42 UTC) #8
Message was sent while issue was closed.
Change committed as 220518

Powered by Google App Engine
This is Rietveld 408576698