Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 23640006: Fix inspector crash when reloading during a debugger pause on a page with unload event handlers (Closed)

Created:
7 years, 3 months ago by Nate Chapin
Modified:
7 years, 3 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, dglazkov+blink, Nate Chapin, eae+blinkwatch, gavinp+loader_chromium.org
Visibility:
Public.

Description

Fix inspector crash when reloading during a debugger pause on a page with unload event handlers This was regressed in r155659. BUG=279919 TEST=manually tested with repro in bug Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157375

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M Source/core/loader/FrameLoader.cpp View 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nate Chapin
I don't have a test for this, but given the fact that this issue appears ...
7 years, 3 months ago (2013-09-05 18:22:38 UTC) #1
abarth-chromium
lgtm ok
7 years, 3 months ago (2013-09-06 05:08:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/23640006/1
7 years, 3 months ago (2013-09-06 16:05:05 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 17:00:55 UTC) #4
Message was sent while issue was closed.
Change committed as 157375

Powered by Google App Engine
This is Rietveld 408576698