Add use counter for insertAdjacentText and insertAdjacentElement

Add use counter for insertAdjacentText and insertAdjacentElement

These two are non standard IE extensions.

BUG=286321
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157455

[ojan, 2013-09-07 17:01:43]

lgtm

insertAdjacentText seems nice as a non-XSSy way to do insertAdjacentHTML.


On Fri, Sep 6, 2013 at 8:31 AM, <arv@chromium.org> wrote:

> Reviewers: Christophe Dumez, ojan,
>
> Description:
> Add use counter for insertAdjacentText and insertAdjacentElement
>
> These two are non standard IE extensions.
>
> BUG=286321
>
> Please review this at
https://codereview.chromium.**org/23638009/<https://codereview.chromium.org/2...
>
> SVN Base:
svn://svn.chromium.org/blink/**trunk<http://svn.chromium.org/blink/trunk>
>
> Affected files (+4, -2 lines):
>   M Source/core/html/HTMLElement.**idl
>   M Source/core/page/UseCounter.h
>
>
> Index: Source/core/html/HTMLElement.**idl
> diff --git a/Source/core/html/**HTMLElement.idl b/Source/core/html/**
> HTMLElement.idl
> index 9894db2725db67a47ebd1b78a170a5**426990b30a..**
> d65a413c63c784e5f339c0f7df44f2**cf65e324b2 100644
> --- a/Source/core/html/**HTMLElement.idl
> +++ b/Source/core/html/**HTMLElement.idl
> @@ -38,11 +38,11 @@
>               [TreatNullAs=NullString, CustomElementCallbacks=Enable,
> SetterRaisesException] attribute DOMString outerHTML;
>               [TreatNullAs=NullString, CustomElementCallbacks=Enable,
> SetterRaisesException] attribute DOMString outerText;
>
> -    [RaisesException, CustomElementCallbacks=Enable] Element
> insertAdjacentElement([**Default=Undefined] optional DOMString where,
> +    [RaisesException, CustomElementCallbacks=Enable,
MeasureAs=**InsertAdjacentElement]
> Element insertAdjacentElement([**Default=Undefined] optional DOMString
> where,
>                                    [Default=Undefined] optional Element
> element);
>      [CustomElementCallbacks=**Enable, RaisesException] void
> insertAdjacentHTML([Default=**Undefined] optional DOMString where,
>                              [Default=Undefined] optional DOMString html);
> -    [RaisesException] void insertAdjacentText([Default=**Undefined]
> optional DOMString where,
> +    [RaisesException, MeasureAs=InsertAdjacentText] void
> insertAdjacentText([Default=**Undefined] optional DOMString where,
>                              [Default=Undefined] optional DOMString text);
>
>      [EnabledAtRuntime=IMEAPI] readonly attribute InputMethodContext
> inputMethodContext;
> Index: Source/core/page/UseCounter.h
> diff --git a/Source/core/page/UseCounter.**h
> b/Source/core/page/UseCounter.**h
> index f70e966cece805512d309f6fff51ae**1ff07e163d..**
> 0f66834833f344cb31da248517427c**e830a70a1e 100644
> --- a/Source/core/page/UseCounter.**h
> +++ b/Source/core/page/UseCounter.**h
> @@ -197,6 +197,8 @@ public:
>          UnprefixedAnimationIterationEv**ent,
>          PrefixedAndUnprefixedAnimation**IterationEvent,
>          EventReturnValue, // Legacy IE extension.
> +        InsertAdjacentText,
> +        InsertAdjacentElement,
>          // Add new features immediately above this line. Don't change
> assigned
>          // numbers of each items, and don't reuse unused slots.
>          NumberOfFeatures, // This enum value must be last.
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[do-not-use, 2013-09-07 17:13:30]

lgtm

[commit-bot: I haz the power, 2013-09-07 17:27:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/arv@chromium.org/23638009/1

[commit-bot: I haz the power, 2013-09-07 17:27:52]

Failed to apply patch for Source/core/page/UseCounter.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/page/UseCounter.h
  Hunk #1 FAILED at 197.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/page/UseCounter.h.rej

Patch:       Source/core/page/UseCounter.h
Index: Source/core/page/UseCounter.h
diff --git a/Source/core/page/UseCounter.h b/Source/core/page/UseCounter.h
index
f70e966cece805512d309f6fff51ae1ff07e163d..0f66834833f344cb31da248517427ce830a70a1e
100644
--- a/Source/core/page/UseCounter.h
+++ b/Source/core/page/UseCounter.h
@@ -197,6 +197,8 @@ public:
         UnprefixedAnimationIterationEvent,
         PrefixedAndUnprefixedAnimationIterationEvent,
         EventReturnValue, // Legacy IE extension.
+        InsertAdjacentText,
+        InsertAdjacentElement,
         // Add new features immediately above this line. Don't change assigned
         // numbers of each items, and don't reuse unused slots.
         NumberOfFeatures, // This enum value must be last.

[arv (Not doing code reviews), 2013-09-07 17:29:17]

On 2013/09/07 17:01:43, ojan wrote:
> lgtm
> 
> insertAdjacentText seems nice as a non-XSSy way to do insertAdjacentHTML.

As you know DOM4 has you covered here using prepend etc.

[commit-bot: I haz the power, 2013-09-09 14:10:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/arv@chromium.org/23638009/9001

[commit-bot: I haz the power, 2013-09-09 15:07:58]

Change committed as 157455