Issue 23638007: Replace GetForProfile with drive::util::Get{DriveService,FileSystem}ByProfile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23638007: Replace GetForProfile with drive::util::Get{DriveService,FileSystem}ByProfile. (Closed)

Created:
7 years, 3 months ago by hidehiko

Modified:
7 years, 3 months ago

Reviewers:
kinaba

CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Replace GetForProfile with drive::util::Get{DriveService,FileSystem}ByProfile. As preparation of migrating Drive disabling setting into Drive File System's mounting state, this replaces GetForProfile, since it will return the instance always (regardless of Drive disabling setting). BUG=284972 TEST=Ran unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221520

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -19 lines)			Patch
	M	chrome/browser/chromeos/drive/file_task_executor.cc	View		4 chunks	+14 lines, -19 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23638007/1

7 years, 3 months ago (2013-09-05 06:51:04 UTC) #3

commit-bot: I haz the power

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=83097

7 years, 3 months ago (2013-09-05 07:30:50 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23638007/1

7 years, 3 months ago (2013-09-05 17:40:53 UTC) #5

Message was sent while issue was closed.

Change committed as 221520

Expand Messages | Collapse Messages