media/base/keyboard_event_counter.cc - Issue 23637005: Fixing a race in KeyboardEventCounter::Reset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/keyboard_event_counter.cc

Issue 23637005: Fixing a race in KeyboardEventCounter::Reset. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/keyboard_event_counter.cc

diff --git a/media/base/keyboard_event_counter.cc b/media/base/keyboard_event_counter.cc

index a4ae1097f8e00d36f85902cac74c2d328c90484d..8432aec37e38171d0dd1ef24057d91a6af8d0dfd 100644

--- a/media/base/keyboard_event_counter.cc

+++ b/media/base/keyboard_event_counter.cc

@@ -15,7 +15,8 @@ KeyboardEventCounter::~KeyboardEventCounter() {}

void KeyboardEventCounter::Reset() {

pressed_keys_.clear();

- total_key_presses_ = 0;

+ base::subtle::NoBarrier_Store(

+ reinterpret_cast<base::subtle::AtomicWord*>(&total_key_presses_), 0);

}

void KeyboardEventCounter::OnKeyboardEvent(ui::EventType event,

« no previous file with comments | « no previous file | no next file » | no next file with comments »