chrome/renderer/extensions/render_view_observer_natives.cc - Issue 23636015: Remove unsafe access hacks from ScopedPersistent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/render_view_observer_natives.cc

Issue 23636015: Remove unsafe access hacks from ScopedPersistent. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: code review (jyasskin)' Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/render_view_observer_natives.cc

diff --git a/chrome/renderer/extensions/render_view_observer_natives.cc b/chrome/renderer/extensions/render_view_observer_natives.cc

index a197c5d7ae3e6a8c040db7c641f8eb550a97c8aa..adb0e9cf1625ae84eba2f0f408cd29b9437afdf5 100644

--- a/chrome/renderer/extensions/render_view_observer_natives.cc

+++ b/chrome/renderer/extensions/render_view_observer_natives.cc

@@ -40,7 +40,7 @@ class LoadWatcher : public content::RenderViewObserver {

void CallbackAndDie(bool succeeded) {

v8::HandleScope handle_scope(context_->isolate());

v8::Handle<v8::Value> args[] = { v8::Boolean::New(succeeded) };

- context_->CallFunction(callback_.get(), 1, args);

+ context_->CallFunction(callback_.NewHandle(context_->isolate()), 1, args);

delete this;

}