Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1677)

Unified Diff: chrome/browser/notifications/message_center_notifications_browsertest.cc

Issue 23636010: Notifications: Add cross-platform UMA: ShowMessageCenter, ShowSettings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added the hash to chromeactions.txt Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/message_center_notifications_browsertest.cc
diff --git a/chrome/browser/notifications/message_center_notifications_browsertest.cc b/chrome/browser/notifications/message_center_notifications_browsertest.cc
index 84cde473fc6c8155b202e0c4229992adfa9e59c1..0883c0039cd2bbdb34c835a0bcce4d7917202731 100644
--- a/chrome/browser/notifications/message_center_notifications_browsertest.cc
+++ b/chrome/browser/notifications/message_center_notifications_browsertest.cc
@@ -23,6 +23,7 @@
#include "content/public/browser/notification_source.h"
#include "ui/message_center/message_center.h"
#include "ui/message_center/message_center_switches.h"
+#include "ui/message_center/message_center_types.h"
#include "ui/message_center/message_center_util.h"
class TestAddObserver : public message_center::MessageCenterObserver {
@@ -283,12 +284,12 @@ IN_PROC_BROWSER_TEST_F(MessageCenterNotificationsTest,
TestDelegate* delegate2;
manager()->Add(CreateTestNotification("n", &delegate), profile());
- message_center()->SetMessageCenterVisible(true);
+ message_center()->SetVisibility(message_center::VISIBILITY_MESSAGE_CENTER);
manager()->Add(CreateTestNotification("n2", &delegate2), profile());
EXPECT_EQ("add-n", observer.log());
- message_center()->SetMessageCenterVisible(false);
+ message_center()->SetVisibility(message_center::VISIBILITY_TRANSIENT);
EXPECT_EQ("add-n_add-n2", observer.log());
@@ -323,7 +324,7 @@ IN_PROC_BROWSER_TEST_F(MessageCenterNotificationsTest,
Notification notification = CreateTestNotification("n", &delegate);
manager()->Add(notification, profile());
message_center()->ClickOnNotification("n");
- message_center()->SetMessageCenterVisible(true);
+ message_center()->SetVisibility(message_center::VISIBILITY_MESSAGE_CENTER);
observer.reset_log();
notification.set_title(ASCIIToUTF16("title2"));
manager()->Update(notification, profile());
@@ -362,7 +363,7 @@ IN_PROC_BROWSER_TEST_F(
Notification notification = CreateTestNotification("n", &delegate);
manager()->Add(notification, profile());
message_center()->ClickOnNotification("n");
- message_center()->SetMessageCenterVisible(true);
+ message_center()->SetVisibility(message_center::VISIBILITY_MESSAGE_CENTER);
observer.reset_log();
notification.set_type(message_center::NOTIFICATION_TYPE_PROGRESS);
manager()->Update(notification, profile());
@@ -401,7 +402,7 @@ IN_PROC_BROWSER_TEST_F(MessageCenterNotificationsTest,
notification.set_type(message_center::NOTIFICATION_TYPE_PROGRESS);
manager()->Add(notification, profile());
message_center()->ClickOnNotification("n");
- message_center()->SetMessageCenterVisible(true);
+ message_center()->SetVisibility(message_center::VISIBILITY_MESSAGE_CENTER);
observer.reset_log();
notification.set_progress(50);
manager()->Update(notification, profile());

Powered by Google App Engine
This is Rietveld 408576698