Add encoded_data_length argument to didDownloadData delegate method

Add encoded_data_length argument to didDownloadData delegate method

When leveraging ResourceRequest downloadToFile option to download
a File directly for XHR response, didDownloadData should propagate
encoded_data_length to notify it to the inspector.

When the Chromium-side patch is landed, didDownloadData definition
without encoded_data_length in WebURLLoaderClient will be removed.

BUG=269055
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156838

[tyoshino (SeeGerritForStatus), 2013-08-28 05:42:24]

lgtm

https://codereview.chromium.org/23632004/diff/8001/public/platform/WebURLLoad...
File public/platform/WebURLLoaderClient.h (right):

https://codereview.chromium.org/23632004/diff/8001/public/platform/WebURLLoad...
public/platform/WebURLLoaderClient.h:59: // FIXME: Remove this stub function
when Chrome-side change propagating the encodedDataLength is landed.
keep comments <= 80 cols

[yusukesuzuki, 2013-08-28 05:49:17]

Thanks for your review.

https://chromiumcodereview.appspot.com/23632004/diff/8001/public/platform/Web...
File public/platform/WebURLLoaderClient.h (right):

https://chromiumcodereview.appspot.com/23632004/diff/8001/public/platform/Web...
public/platform/WebURLLoaderClient.h:59: // FIXME: Remove this stub function
when Chrome-side change propagating the encodedDataLength is landed.
On 2013/08/28 05:42:24, tyoshino wrote:
> keep comments <= 80 cols

Done.

[yusukesuzuki, 2013-08-28 05:52:31]

Oops, sorry. I've fixed the reviewers list.

[abarth-chromium, 2013-08-28 06:38:23]

I don't fully understand why we care about the encoded data length, but LGTM

[yusukesuzuki, 2013-08-28 06:47:38]

On 2013/08/28 06:38:23, abarth wrote:
> I don't fully understand why we care about the encoded data length, but LGTM

This is because the Inspector requires the data length and the encoded data
length to show Size/Content values in the Network panel.
The document[1] for this issue[2] describes the design and why the encoded data
length is needed.

[1]:
https://docs.google.com/document/d/1pWFNc6paT_kohDbYGd3qYtPWVw82SPWv1LR0VxZ9Q...
[2]: http://crbug.com/269055

[abarth-chromium, 2013-08-28 06:52:50]

Makes sense.  Thanks for the links!

[yusukesuzuki, 2013-08-28 08:42:48]

Previously I sent the above design document to japhet and got his agreement
about this design of adding encodedDataLength to didDownloadData arguments.
So I'll commit it. Please read it later, japhet.

[commit-bot: I haz the power, 2013-08-28 08:46:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukesuzuki@chromium.org/23632004/14001

[commit-bot: I haz the power, 2013-08-28 10:46:30]

Change committed as 156838