Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 23629032: mojo: MessageBuilder (Closed)

Created:
7 years, 3 months ago by darin (slow to review)
Modified:
7 years, 3 months ago
Reviewers:
vtl, viettrungluu
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Switch to std::vector and add support for Handle. #

Patch Set 5 : Add support for a string field type. #

Total comments: 9

Patch Set 6 : Improvements based on review feedback. #

Patch Set 7 : #

Patch Set 8 : New and improved directory structure and file names. #

Total comments: 5

Patch Set 9 : Address review feedback. #

Patch Set 10 : Rebase #

Patch Set 11 : Fix compiler warnings #

Patch Set 12 : Switch to base/logging and use COMPILE_ASSERT #

Patch Set 13 : Fix mis-alignment oops. #

Patch Set 14 : Add TODO comment. #

Patch Set 15 : Fix compilation error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+524 lines, -0 lines) Patch
M build/all.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
A mojo/mojo.gyp View 1 2 3 4 5 6 7 1 chunk +49 lines, -0 lines 0 comments Download
A mojo/public/libs/message/README View 1 2 3 4 5 6 7 8 9 10 1 chunk +40 lines, -0 lines 0 comments Download
A mojo/public/libs/message/message.h View 1 2 3 4 5 6 7 8 1 chunk +57 lines, -0 lines 0 comments Download
A mojo/public/libs/message/message.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +15 lines, -0 lines 0 comments Download
A mojo/public/libs/message/message_builder.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +70 lines, -0 lines 0 comments Download
A mojo/public/libs/message/message_builder.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +189 lines, -0 lines 0 comments Download
A mojo/public/libs/message/message_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +83 lines, -0 lines 0 comments Download
A mojo/public/system/core.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
vtl
I haven't looked at the implementation super-closely, but here are some comments.... Also, I've been ...
7 years, 3 months ago (2013-09-11 17:37:15 UTC) #1
vtl
https://codereview.chromium.org/23629032/diff/10001/mojo/ipc/message/README File mojo/ipc/message/README (right): https://codereview.chromium.org/23629032/diff/10001/mojo/ipc/message/README#newcode25 mojo/ipc/message/README:25: [ U16 ] Another thought occurred to me: Maybe ...
7 years, 3 months ago (2013-09-12 01:16:10 UTC) #2
darin (slow to review)
On Wed, Sep 11, 2013 at 10:37 AM, <vtl@google.com> wrote: > I haven't looked at ...
7 years, 3 months ago (2013-09-12 05:15:09 UTC) #3
darin (slow to review)
On 2013/09/12 01:16:10, vtl wrote: > https://codereview.chromium.org/23629032/diff/10001/mojo/ipc/message/README > File mojo/ipc/message/README (right): > > https://codereview.chromium.org/23629032/diff/10001/mojo/ipc/message/README#newcode25 > ...
7 years, 3 months ago (2013-09-12 05:15:25 UTC) #4
darin (slow to review)
I think I'll actually leave out the 0 byte case for now. I don't see ...
7 years, 3 months ago (2013-09-12 05:17:39 UTC) #5
Avi (use Gerrit)
drive-by nitpicking https://codereview.chromium.org/23629032/diff/10001/mojo/ipc/message/ipc_message_unittest.cc File mojo/ipc/message/ipc_message_unittest.cc (right): https://codereview.chromium.org/23629032/diff/10001/mojo/ipc/message/ipc_message_unittest.cc#newcode1 mojo/ipc/message/ipc_message_unittest.cc:1: // Copyright (c) 2013 The Chromium Authors. ...
7 years, 3 months ago (2013-09-12 05:29:32 UTC) #6
darin (slow to review)
Thank you! I always just copy/paste copyright headers. Then the server modifies my commit, and ...
7 years, 3 months ago (2013-09-12 05:32:32 UTC) #7
viettrungluu
LGTM (with issues below fixed), though of course the message format is still subject to ...
7 years, 3 months ago (2013-09-13 16:40:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/23629032/22002
7 years, 3 months ago (2013-09-15 07:48:50 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-15 08:03:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/23629032/61001
7 years, 3 months ago (2013-09-15 18:20:18 UTC) #11
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-15 18:24:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/23629032/61001
7 years, 3 months ago (2013-09-15 18:43:21 UTC) #13
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 02:55:21 UTC) #14
Message was sent while issue was closed.
Change committed as 223304

Powered by Google App Engine
This is Rietveld 408576698