Add deletion to the activityLogPrivate API

Add deletion to the activityLogPrivate API

* Automatically delete the whole database when Watchdog is uninstalled
* Give the activityLogPrivate API the ability to delete the entire database
* Give the activityLogPrivate API the ability to selectively delete URLs

BUG=277260
R=mpcomplete@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221622

[felt, 2013-08-31 01:09:31]

Hi Matt, can you please review this CL?

Adrienne

[felt, 2013-09-03 15:58:48]

On 2013/08/31 01:09:31, felt wrote:
> Hi Matt, can you please review this CL?
> 
> Adrienne

hey Matt, quick ping so this doesn't get lost in the shuffle of long weekend
emails

[Matt Perry, 2013-09-03 19:21:26]

https://codereview.chromium.org/23629015/diff/1015/chrome/common/extensions/a...
File chrome/common/extensions/api/activity_log_private.json (right):

https://codereview.chromium.org/23629015/diff/1015/chrome/common/extensions/a...
chrome/common/extensions/api/activity_log_private.json:94: "description":
"Erases only the URLs listed; if empty, erases all URLs.",
how is deleteUrls([]) different from deleteDatabase?

[felt, 2013-09-03 19:55:35]

https://codereview.chromium.org/23629015/diff/1015/chrome/common/extensions/a...
File chrome/common/extensions/api/activity_log_private.json (right):

https://codereview.chromium.org/23629015/diff/1015/chrome/common/extensions/a...
chrome/common/extensions/api/activity_log_private.json:94: "description":
"Erases only the URLs listed; if empty, erases all URLs.",
On 2013/09/03 19:21:27, Matt Perry wrote:
> how is deleteUrls([]) different from deleteDatabase?

deleteURLs erases only the URLs (either specific URLs or all URLs).
deleteDatabase nukes the whole database, both the url-related fields as well as
all other fields.

[Matt Perry, 2013-09-03 20:08:50]

lgtm

[commit-bot: I haz the power, 2013-09-03 21:21:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/felt@chromium.org/23629015/11001

[commit-bot: I haz the power, 2013-09-04 00:37:21]

Failed to apply patch for
chrome/browser/extensions/extension_function_histogram_value.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/extension_function_histogram_value.h
  Hunk #1 FAILED at 621.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/extensions/extension_function_histogram_value.h.rej

Patch:       chrome/browser/extensions/extension_function_histogram_value.h
Index: chrome/browser/extensions/extension_function_histogram_value.h
diff --git a/chrome/browser/extensions/extension_function_histogram_value.h
b/chrome/browser/extensions/extension_function_histogram_value.h
index
97ca08df7ea877364791facdc71f3104ddcd32a2..91518e57c5ed599384021b58c6e14d8f00725b88
100644
--- a/chrome/browser/extensions/extension_function_histogram_value.h
+++ b/chrome/browser/extensions/extension_function_histogram_value.h
@@ -621,6 +621,8 @@ enum HistogramValue {
   FILEBROWSERPRIVATE_INSTALLWEBSTOREITEM,
   FILEBROWSERPRIVATE_STARTCOPY,
   FILEBROWSERPRIVATE_CANCELCOPY,
+  ACTIVITYLOGPRIVATE_DELETEDATABASE,
+  ACTIVITYLOGPRIVATE_DELETEURLS,
   ENUM_BOUNDARY // Last entry: Add new entries above.
 };

[commit-bot: I haz the power, 2013-09-04 01:03:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/felt@chromium.org/23629015/35001

[commit-bot: I haz the power, 2013-09-04 16:42:00]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-09-04 20:03:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/felt@chromium.org/23629015/35001

[commit-bot: I haz the power, 2013-09-04 21:34:57]

Failed to apply patch for
chrome/browser/extensions/extension_function_histogram_value.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/extension_function_histogram_value.h
  Hunk #1 FAILED at 622.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/extensions/extension_function_histogram_value.h.rej

Patch:       chrome/browser/extensions/extension_function_histogram_value.h
Index: chrome/browser/extensions/extension_function_histogram_value.h
diff --git a/chrome/browser/extensions/extension_function_histogram_value.h
b/chrome/browser/extensions/extension_function_histogram_value.h
index
d1a11546e880fa8e4b53d236b1303c5a9695c52c..8d88c24bd61cc4dbc82afd32ed6639188b96efac
100644
--- a/chrome/browser/extensions/extension_function_histogram_value.h
+++ b/chrome/browser/extensions/extension_function_histogram_value.h
@@ -622,6 +622,8 @@ enum HistogramValue {
   FILEBROWSERPRIVATE_STARTCOPY,
   FILEBROWSERPRIVATE_CANCELCOPY,
   NETWORKINGPRIVATE_CREATENETWORK,
+  ACTIVITYLOGPRIVATE_DELETEDATABASE,
+  ACTIVITYLOGPRIVATE_DELETEURLS,
   ENUM_BOUNDARY // Last entry: Add new entries above.
 };

[commit-bot: I haz the power, 2013-09-05 01:50:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/felt@chromium.org/23629015/62001

[commit-bot: I haz the power, 2013-09-05 20:26:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/felt@chromium.org/23629015/76001

[commit-bot: I haz the power, 2013-09-05 20:26:44]

Failed to trigger a try job on chromium_presubmit
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2013-09-05 20:41:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/felt@chromium.org/23629015/75001

[commit-bot: I haz the power, 2013-09-06 07:22:57]

Change committed as 221622