Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23627008: Replace FileResource::set_labels with mutable_labels (Closed)

Created:
7 years, 3 months ago by tzik
Modified:
7 years, 3 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Replace FileResource::set_labels with mutable_labels Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221754

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/google_apis/drive_api_parser.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tzik
PTAL, Kinaba-san. set_labels() will not work since FileLabels is not copyable. May I replace this ...
7 years, 3 months ago (2013-09-06 10:44:31 UTC) #1
kinaba
lgtm
7 years, 3 months ago (2013-09-06 13:57:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/23627008/1
7 years, 3 months ago (2013-09-06 16:29:43 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 19:34:17 UTC) #4
Message was sent while issue was closed. 
Change committed as 221754

Powered by Google App Engine
This is Rietveld 408576698