Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1924)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.h

Issue 23624002: Add UI for RuntimeErrors in the ErrorConsole (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ec_merge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.h
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.h b/chrome/browser/ui/webui/extensions/extension_settings_handler.h
index 17bf2f50b91d0555363e3c0c6c5c7282db8bb074..424604798c992476a40418e4417e7c6cd0c90923 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.h
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.h
@@ -12,6 +12,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/prefs/pref_change_registrar.h"
#include "base/scoped_observer.h"
+#include "chrome/browser/extensions/error_console/error_console.h"
#include "chrome/browser/extensions/extension_install_prompt.h"
#include "chrome/browser/extensions/extension_install_ui.h"
#include "chrome/browser/extensions/extension_uninstall_dialog.h"
@@ -67,6 +68,7 @@ class ExtensionSettingsHandler
public content::NotificationObserver,
public content::WebContentsObserver,
public ui::SelectFileDialog::Listener,
+ public ErrorConsole::Observer,
public ExtensionInstallPrompt::Delegate,
public ExtensionUninstallDialog::Delegate,
public ExtensionWarningService::Observer,
@@ -112,7 +114,10 @@ class ExtensionSettingsHandler
void* params) OVERRIDE;
virtual void MultiFilesSelected(
const std::vector<base::FilePath>& files, void* params) OVERRIDE;
- virtual void FileSelectionCanceled(void* params) OVERRIDE {}
+ virtual void FileSelectionCanceled(void* params) OVERRIDE;
+
+ // ErrorConsole::Observer implementation.
+ virtual void OnErrorAdded(const ExtensionError* error) OVERRIDE;
// content::NotificationObserver implementation.
virtual void Observe(int type,
@@ -263,6 +268,9 @@ class ExtensionSettingsHandler
ScopedObserver<ExtensionWarningService, ExtensionWarningService::Observer>
warning_service_observer_;
+ // An observer to listen for when Extension errors are reported.
+ ScopedObserver<ErrorConsole, ErrorConsole::Observer> error_console_observer_;
+
DISALLOW_COPY_AND_ASSIGN(ExtensionSettingsHandler);
};

Powered by Google App Engine
This is Rietveld 408576698