Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1652)

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 23624002: Add UI for RuntimeErrors in the ErrorConsole (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ec_merge
Patch Set: Yoyo's and Ben's Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index ec0b53e578e8b12f2296b3883925af97f15e0bf1..c8a9405a5967485b1ab362eaf9ac79036d620b35 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -305,14 +305,22 @@ cr.define('options', function() {
});
}
- // The manifest errors and warnings, in one of two formats (depending on
- // if the ErrorConsole is enabled).
+ // If the ErrorConsole is enabled, we should have manifest and/or runtime
+ // errors. Otherwise, we may have install warnings. We should not have
+ // both ErrorConsole errors and install warnings.
if (extension.manifestErrors) {
- var manifestErrors = node.querySelector('.manifest-errors');
- manifestErrors.hidden = false;
- manifestErrors.appendChild(
- new extensions.ExtensionErrorList(extension.manifestErrors));
- } else if (extension.installWarnings) {
+ var panel = node.querySelector('.manifest-errors');
+ panel.hidden = false;
+ panel.appendChild(new extensions.ExtensionErrorList(
+ extension.manifestErrors, 'manifest'));
+ }
+ if (extension.runtimeErrors) {
+ var panel = node.querySelector('.runtime-errors');
+ panel.hidden = false;
+ panel.appendChild(new extensions.ExtensionErrorList(
+ extension.runtimeErrors, 'runtime'));
+ }
+ if (extension.installWarnings) {
var panel = node.querySelector('.install-warnings');
panel.hidden = false;
var list = panel.querySelector('ul');

Powered by Google App Engine
This is Rietveld 408576698