Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: extensions/browser/extension_error.h

Issue 23624002: Add UI for RuntimeErrors in the ErrorConsole (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ec_merge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/extension_error.h
diff --git a/extensions/browser/extension_error.h b/extensions/browser/extension_error.h
index 7e02bb33f89e18da20ddf1d696d911fcde973559..dff80ee25f6c123cb686acc636dea4a95aa18a84 100644
--- a/extensions/browser/extension_error.h
+++ b/extensions/browser/extension_error.h
@@ -128,10 +128,21 @@ class RuntimeError : public ExtensionError {
logging::LogSeverity level);
virtual ~RuntimeError();
+ virtual scoped_ptr<base::DictionaryValue> ToValue() const OVERRIDE;
+
virtual std::string PrintForTest() const OVERRIDE;
const GURL& context_url() const { return context_url_; }
const StackTrace& stack_trace() const { return stack_trace_; }
+
+ // Keys used for retrieving JSON values.
+ static const char kColumnNumberKey[];
+ static const char kContextUrlKey[];
+ static const char kFunctionNameKey[];
+ static const char kLineNumberKey[];
+ static const char kStackTraceKey[];
+ static const char kUrlKey[];
+
private:
virtual bool IsEqualImpl(const ExtensionError* rhs) const OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698