Add UI for RuntimeErrors in the ErrorConsole

extensions/browser/extension_error.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/extension_error.h"
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "extensions/common/constants.h"
@@ skipping 102 matching lines @@
   return ExtensionError::PrintForTest() +
          "\n  Type:    ManifestError";
 }
 
 bool ManifestError::IsEqualImpl(const ExtensionError* rhs) const {
   // If two manifest errors have the same extension id and message (which are
   // both checked in ExtensionError::IsEqual), then they are equal.
   return true;
 }
 
+////////////////////////////////////////////////////////////////////////////////
+// RuntimeError
+
+// Static JSON keys.
+const char RuntimeError::kColumnNumberKey[] = "columnNumber";
+const char RuntimeError::kContextUrlKey[] = "contextUrl";
+const char RuntimeError::kFunctionNameKey[] = "functionName";
+const char RuntimeError::kLineNumberKey[] = "lineNumber";
+const char RuntimeError::kStackTraceKey[] = "stackTrace";
+const char RuntimeError::kUrlKey[] = "url";
+
 RuntimeError::RuntimeError(bool from_incognito,
                            const string16& source,
                            const string16& message,
                            const StackTrace& stack_trace,
                            const GURL& context_url,
                            logging::LogSeverity level)
     : ExtensionError(ExtensionError::RUNTIME_ERROR,
                      GURL(source).host(),
                      from_incognito,
                      level,
                      source,
                      message),
       context_url_(context_url),
       stack_trace_(stack_trace) {
   CleanUpInit();
 }
 
 RuntimeError::~RuntimeError() {
 }
 
+scoped_ptr<DictionaryValue> RuntimeError::ToValue() const {
+  scoped_ptr<DictionaryValue> value = ExtensionError::ToValue();
+  value->SetString(kContextUrlKey, context_url_.spec());
+
+  ListValue* trace_value = new ListValue;
+  for (StackTrace::const_iterator iter = stack_trace_.begin();
+       iter != stack_trace_.end(); ++iter) {
+    DictionaryValue* frame_value = new DictionaryValue;
+    frame_value->SetInteger(kLineNumberKey, iter->line_number);
+    frame_value->SetInteger(kColumnNumberKey, iter->column_number);
+    frame_value->SetString(kUrlKey, iter->source);
+    frame_value->SetString(kFunctionNameKey, iter->function);
+    trace_value->Append(frame_value);
+  }
+
+  value->Set(kStackTraceKey, trace_value);
+
+  return value.Pass();
+}
+
 std::string RuntimeError::PrintForTest() const {
   std::string result = ExtensionError::PrintForTest() +
          "\n  Type:    RuntimeError"
          "\n  Context: " + context_url_.spec() +
          "\n  Stack Trace: ";
   for (StackTrace::const_iterator iter = stack_trace_.begin();
        iter != stack_trace_.end(); ++iter) {
     result += "\n    {"
               "\n      Line:     " + base::IntToString(iter->line_number) +
               "\n      Column:   " + base::IntToString(iter->column_number) +
@@ skipping 32 matching lines @@
   // other systems), the source won't match up with the final entry in the stack
   // trace. (For instance, in a browser action error, the source is the page -
   // sometimes the background page - but the error is thrown from the script.)
   // Make the source match the stack trace, since that is more likely the cause
   // of the error.
   if (!stack_trace_.empty() && source_ != stack_trace_[0].source)
     source_ = stack_trace_[0].source;
 }
 
 }  // namespace extensions