Add UI for RuntimeErrors in the ErrorConsole

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="extension_error.js"></include>
 
 cr.define('options', function() {
   'use strict';
 
   /**
@@ skipping 287 matching lines @@
       // The extension warnings (describing runtime issues).
       if (extension.warnings) {
         var panel = node.querySelector('.extension-warnings');
         panel.hidden = false;
         var list = panel.querySelector('ul');
         extension.warnings.forEach(function(warning) {
           list.appendChild(document.createElement('li')).innerText = warning;
         });
       }
 
-      // The manifest errors and warnings, in one of two formats (depending on
-      // if the ErrorConsole is enabled).
-      if (extension.manifestErrors) {
-        var manifestErrors = node.querySelector('.manifest-errors');
-        manifestErrors.hidden = false;
-        manifestErrors.appendChild(
-            new extensions.ExtensionErrorList(extension.manifestErrors));
+      // If the ErrorConsole is enabled, handle the manifest and runtime errors.
+      // Otherwise, handle any install warnings.
+      if (extension.manifestErrors || extension.runtimeErrors) {
+        if (extension.manifestErrors) {
+          var panel = node.querySelector('.manifest-errors-wrapper');
+          panel.hidden = false;
+          panel.appendChild(new extensions.ExtensionErrorList(
+              extension.manifestErrors, 'manifest'));
+        }
+        if (extension.runtimeErrors) {
+          var panel = node.querySelector('.runtime-errors-wrapper');
+          panel.hidden = false;
+          panel.appendChild(new extensions.ExtensionErrorList(
+              extension.runtimeErrors, 'runtime'));
+        }
       } else if (extension.installWarnings) {

[not at google - send to devlin, 2013/09/05 00:37:16]

I'm puzzled by the else here. Why can't this be:

if (extension.manifestErrors) {
  ... manifest error stuff
}

if (extension.runtimeErrors) {
  ... runtime error stuff
}

if (extension.installWarnings) {
  ... install warning stuff
}

[Devlin, 2013/09/05 17:53:55]

It can be. I had it like that for two reasons:
1. It makes the logic for possible entities more clear: if we have
runtime/manifest errors, we do not have install warnings.
2. It adds an extra layer to make sure we don't show something silly if our
assumptions are ever wrong (even though they shouldn't be).

But, of course, if the block is more puzzling than the alternative, clearly #1
failed. So changed. :)

[not at google - send to devlin, 2013/09/06 17:05:19]

Yeah - it would be simpler to just render what we're told to. Let the C++ code
(which is actually testable) enforce consistency.

         var panel = node.querySelector('.install-warnings');
         panel.hidden = false;
         var list = panel.querySelector('ul');
         extension.installWarnings.forEach(function(warning) {
           var li = document.createElement('li');
           li.innerText = warning.message;
           list.appendChild(li);
         });
       }
 
       this.appendChild(node);
       if (location.hash.substr(1) == extension.id) {
         // Scroll beneath the fixed header so that the extension is not
         // obscured.
         var topScroll = node.offsetTop - $('page-header').offsetHeight;
         var pad = parseInt(getComputedStyle(node, null).marginTop, 10);
         if (!isNaN(pad))
           topScroll -= pad / 2;
         document.body.scrollTop = topScroll;
       }
     },
   };
 
   return {
     ExtensionsList: ExtensionsList
   };
 });