chrome/browser/resources/extensions/extension_error.html - Issue 23624002: Add UI for RuntimeErrors in the ErrorConsole

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/extensions/extension_error.html

Issue 23624002: Add UI for RuntimeErrors in the ErrorConsole (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ec_merge

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/extensions/extension_error.css ('k') | chrome/browser/resources/extensions/extension_error.js » ('j') | chrome/browser/resources/extensions/extension_error.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!--	1 <!--

2 Copyright 2013 The Chromium Authors. All rights reserved.	2 Copyright 2013 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be found	3 Use of this source code is governed by a BSD-style license that can be found

4 in the LICENSE file.	4 in the LICENSE file.

5 -->	5 -->

6 <div id="template-collection-extension-error" hidden>	6 <div id="template-collection-extension-error" hidden>

7 <div class="extension-error-list">	7 <div class="extension-error-list">

8 <span i18n-content="extensionErrorsManifestErrors"></span>	8 <span class="extension-error-list-title"></span>

9 <ul class="extension-error-list-contents"></ul>	9 <ul class="extension-error-list-contents"></ul>

10 <div class="extension-error-list-show-more">	10 <div class="extension-error-list-show-more">

11 <a i18n-content="extensionErrorsShowMore" hidden></a>	11 <a i18n-content="extensionErrorsShowMore" hidden></a>

12 </div>	12 </div>

13 </div>	13 </div>

	14

	15 <div class="extension-error-detailed-wrapper">
	not at google - send to devlin 2013/09/05 00:37:16 "detailed" seems deliberate here but it looks weir "detailed" seems deliberate here but it looks weird, maybe comments would help here... but I'm not that familiar with the idiom of comments in webui Devlin 2013/09/05 17:53:55 I don't usually see comments in the HTML, but we c Show quoted text On 2013/09/05 00:37:16, kalman wrote: > "detailed" seems deliberate here but it looks weird, maybe comments would help > here... but I'm not that familiar with the idiom of comments in webui I don't usually see comments in the HTML, but we can add them if they're necessary. Does the addition of simple-wrapper here make it clear enough, or would more explanation be better?
	16 <details>

	17 <summary></summary>

	18 <div class="extension-error-details"></div>

	19 </details>

	20 </div>

	21

14 <div class="extension-error-metadata">	22 <div class="extension-error-metadata">

15 <span class="extension-error-message"></span>	23 <span class="extension-error-message"></span>

16 </div>	24 </div>

	25

	26 <div class="extension-error-context-wrapper">

	27 <span i18n-content="extensionErrorContext"></span>

	28 <a></a>

	29 </div>

	30

	31 <details class="extension-error-stack-trace">

	32 <summary class="extension-error-stack-trace-label"

	33 i18n-content="extensionErrorStackTrace"></summary>

	34 <ul class="extension-error-stack-trace-list"></ul>

	35 </details>

17 </div>	36 </div>

OLD	NEW