components/autofill/content/renderer/password_generation_manager.cc - Issue 23622013: Move password_form_conversion_utils out of //content into //autofill.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_generation_manager.cc

Issue 23622013: Move password_form_conversion_utils out of //content into //autofill. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@password_form_includes_removal

Patch Set: Add bug reference for components_browsertests Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc ('k') | content/content_renderer.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_generation_manager.cc

diff --git a/components/autofill/content/renderer/password_generation_manager.cc b/components/autofill/content/renderer/password_generation_manager.cc

index aa50cdc0b4dd69e531aa5e5a360c12e730482687..bdca3e45cec07fde3e65d0eb1984b6b60684ce08 100644

--- a/components/autofill/content/renderer/password_generation_manager.cc

+++ b/components/autofill/content/renderer/password_generation_manager.cc

@@ -5,9 +5,9 @@

#include "components/autofill/content/renderer/password_generation_manager.h"

#include "base/logging.h"

+#include "components/autofill/content/renderer/password_form_conversion_utils.h"

#include "components/autofill/core/common/autofill_messages.h"

#include "components/autofill/core/common/password_generation_util.h"

-#include "content/public/renderer/password_form_conversion_utils.h"

#include "content/public/renderer/render_view.h"

#include "google_apis/gaia/gaia_urls.h"

#include "third_party/WebKit/public/platform/WebCString.h"

@@ -109,7 +109,7 @@ void PasswordGenerationManager::DidFinishLoad(WebKit::WebFrame* frame) {

// If we can't get a valid PasswordForm, we skip this form because the

// the password won't get saved even if we generate it.

scoped_ptr<content::PasswordForm> password_form(

- content::CreatePasswordForm(forms[i]));

+ CreatePasswordForm(forms[i]));

if (!password_form.get()) {

DVLOG(2) << "Skipping form as it would not be saved";

continue;

@@ -155,7 +155,7 @@ void PasswordGenerationManager::openPasswordGenerator(

WebKit::WebElement button(element.passwordGeneratorButtonElement());

gfx::Rect rect(button.boundsInViewportSpace());

scoped_ptr<content::PasswordForm> password_form(

- content::CreatePasswordForm(element.form()));

+ CreatePasswordForm(element.form()));

// We should not have shown the icon we can't create a valid PasswordForm.

DCHECK(password_form.get());