android: Remove GetSDK() from install_emulator_deps.

android: Remove GetSDK() from install_emulator_deps.

These days, the SDK is already checked out by DEPS in
src/third_party/android_tools/sdk, so trying to download it again from a
different location at a later stage does not make much sense.

R=peter@chromium.org,bulach@chromium.org,craigdh@chromium.org,frankf@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222121

[Peter Beverloo, 2013-09-09 17:36:11]

https://codereview.chromium.org/23621025/diff/1/build/android/install_emulato...
File build/android/install_emulator_deps.py (right):

https://codereview.chromium.org/23621025/diff/1/build/android/install_emulato...
build/android/install_emulator_deps.py:8: The script will download the SDK and
system images, if they are not present, and
nit: this comment no longer is accurate.

https://codereview.chromium.org/23621025/diff/1/build/android/install_emulato...
build/android/install_emulator_deps.py:105: # Calls below will download emulator
SDK and/or system images only if needed.
nit: this comment no longer is accurate.

https://codereview.chromium.org/23621025/diff/1/build/android/install_emulato...
build/android/install_emulator_deps.py:108: '.gclient file is correct.')
nit: perhaps we can link to the Android build instructions here? It specifically
is the target_os rule which someone must add:

https://code.google.com/p/chromium/wiki/AndroidBuildInstructions

[bulach, 2013-09-09 18:58:27]

lgtm % nits, thanks!

https://codereview.chromium.org/23621025/diff/1/build/android/install_emulato...
File build/android/install_emulator_deps.py (right):

https://codereview.chromium.org/23621025/diff/1/build/android/install_emulato...
build/android/install_emulator_deps.py:105: # Calls below will download emulator
SDK and/or system images only if needed.
On 2013/09/09 17:36:11, Peter Beverloo wrote:
> nit: this comment no longer is accurate.

yeah, but the x86 below in 112 would still need this comment, perhaps just move
to 112?

[Raphael Kubo da Costa (rakuco), 2013-09-09 19:37:19]

Thanks. I've uploaded a second version of the patch that hopefully addresses all
the comments. Do I need another +1?

[commit-bot: I haz the power, 2013-09-09 19:49:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/236210...

[commit-bot: I haz the power, 2013-09-09 22:54:11]

Change committed as 222121

[navabi, 2013-10-03 17:50:03]

On 2013/09/09 22:54:11, I haz the power (commit-bot) wrote:
> Change committed as 222121

We should do one of the following
1) Revert this and abandon https://codereview.chromium.org/23513022/
2) Leave this and finish https://codereview.chromium.org/23513022/

I prefer 2.

[navabi, 2013-10-03 17:51:40]

On 2013/10/03 17:50:03, navabi wrote:
> On 2013/09/09 22:54:11, I haz the power (commit-bot) wrote:
> > Change committed as 222121
> 
> We should do one of the following
> 1) Revert this and abandon https://codereview.chromium.org/23513022/
> 2) Leave this and finish https://codereview.chromium.org/23513022/
> 
> I prefer 2.

3) Bring back GetSDK() and have it checkout SDK into src dir, and finish
https://codereview.chromium.org/23513022/

I actually prefer 3.

[Raphael Kubo da Costa (rakuco), 2013-10-04 11:16:43]

On 2013/10/03 17:51:40, navabi wrote:
> On 2013/10/03 17:50:03, navabi wrote:
> > On 2013/09/09 22:54:11, I haz the power (commit-bot) wrote:
> > > Change committed as 222121
> > 
> > We should do one of the following
> > 1) Revert this and abandon https://codereview.chromium.org/23513022/
> > 2) Leave this and finish https://codereview.chromium.org/23513022/
> > 
> > I prefer 2.
> 
> 3) Bring back GetSDK() and have it checkout SDK into src dir, and finish
> https://codereview.chromium.org/23513022/
> 
> I actually prefer 3.

Fine for me. I've created
http://code.google.com/p/chromium/issues/detail?id=304129 to track all the
changes and try to centralize all the discussions in a single place.