Replace SkTScopedPtr with SkAutoTDelete in Skia.

Replace SkTScopedPtr with SkAutoTDelete in Skia.

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=11016

[mtklein, 2013-08-29 15:41:44]

Pending the change to remove the useless #include in Chromium.  Android's now
cleaned up.  +reed because this removes public Skia API.

[reed1, 2013-08-29 15:49:59]

lgtm

https://codereview.chromium.org/23621005/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

https://codereview.chromium.org/23621005/diff/1/src/pdf/SkPDFDevice.cpp#newco...
src/pdf/SkPDFDevice.cpp:1681: newEntry.detach();
I know this is not new to your CL, but this just looks odd... calling detach()
but not "taking" the returned ptr.

[tomhudson, 2013-08-29 15:51:57]

This is good, including details like we're now using SkDELETE() here.

Is the SkTScopedPtr class documentation a good description of what's going on in
SkAutoTDelete? If so, can we port it over?
SkTemplates.h is part of the public API.

[mtklein, 2013-08-29 15:59:03]

Yes, the class comment was a perfect description of SkAutoTDelete too.  I've
ported it over nearly verbatim.

https://codereview.chromium.org/23621005/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

https://codereview.chromium.org/23621005/diff/1/src/pdf/SkPDFDevice.cpp#newco...
src/pdf/SkPDFDevice.cpp:1681: newEntry.detach();
On 2013/08/29 15:50:00, reed1 wrote:
> I know this is not new to your CL, but this just looks odd... calling detach()
> but not "taking" the returned ptr.

Totally agree.  Took me a while to figure out newEntry and entry are aliases at
this point.

I'm happy to follow up on this, but I want to keep this change purely
mechanical.

[vandebo (ex-Chrome), 2013-08-29 16:20:18]

https://codereview.chromium.org/23621005/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

https://codereview.chromium.org/23621005/diff/1/src/pdf/SkPDFDevice.cpp#newco...
src/pdf/SkPDFDevice.cpp:1681: newEntry.detach();
On 2013/08/29 15:59:03, mtklein wrote:
> On 2013/08/29 15:50:00, reed1 wrote:
> > I know this is not new to your CL, but this just looks odd... calling
detach()
> > but not "taking" the returned ptr.
> 
> Totally agree.  Took me a while to figure out newEntry and entry are aliases
at
> this point.
> 
> I'm happy to follow up on this, but I want to keep this change purely
> mechanical.

Yes, they are aliases, and I suspect the logic when they aren't aliases is
incorrect. Piled pretty dead, but I'll leave it on my todo list if someone else
doesn't get to it sooner.

[commit-bot: I haz the power, 2013-08-29 22:05:04]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/mtklein@google.com/23621005/7001

[commit-bot: I haz the power, 2013-08-29 22:14:14]

Change committed as 11016