Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23620060: Try to enable software mirror mode in UI message loop after Init() (Closed)

Created:
7 years, 3 months ago by oshima
Modified:
7 years, 3 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Try to enable software mirror mode in UI message loop after Init() This wasn't necessary because chrome used to get extra event. We know ignore redundant events and may not process any display change event, so we need to explicitly run extra task to see if we need to create mirror window. BUG=293015 TEST=see bug for manual test. Also covered by unit test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224197

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -45 lines) Patch
M ash/ash_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/ash_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/display/display_manager.h View 1 chunk +8 lines, -0 lines 0 comments Download
M ash/display/display_manager.cc View 1 10 chunks +41 lines, -41 lines 0 comments Download
M ash/display/mirror_window_controller_unittest.cc View 4 chunks +32 lines, -0 lines 0 comments Download
M ash/shell.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M ash/shell/window_watcher_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ash/test/ash_test_base.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
oshima
7 years, 3 months ago (2013-09-19 00:07:15 UTC) #1
Jun Mukai
lgtm
7 years, 3 months ago (2013-09-19 00:14:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/23620060/8001
7 years, 3 months ago (2013-09-19 01:20:09 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=155719
7 years, 3 months ago (2013-09-19 02:17:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/23620060/8001
7 years, 3 months ago (2013-09-19 08:05:17 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=155782
7 years, 3 months ago (2013-09-19 09:14:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/23620060/36001
7 years, 3 months ago (2013-09-19 16:48:05 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-19 20:03:12 UTC) #8
Message was sent while issue was closed. 
Change committed as 224197

Powered by Google App Engine
This is Rietveld 408576698