Fix the bluetooth audio device id changing on the fly issue and the active device inconsistent issu…

Fix the bluetooth audio device id changing on the fly issue and the active device inconsistent issue caused by multiple NodesChanged signal received for the same node change.


BUG=290485
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223507

[rkc, 2013-09-16 22:38:11]

https://codereview.chromium.org/23620055/diff/1/chromeos/audio/cras_audio_han...
File chromeos/audio/cras_audio_handler.cc (right):

https://codereview.chromium.org/23620055/diff/1/chromeos/audio/cras_audio_han...
chromeos/audio/cras_audio_handler.cc:34: return a.id == b.id && a.is_input ==
b.is_input && a.type == b.type
Shouldn't just comparing the id's be enough? IIRC, the device ID we get up to
Chrome is an OR of (device_id << 32 | node_id), which should make it unique?

[jennyz, 2013-09-16 22:47:03]

https://codereview.chromium.org/23620055/diff/1/chromeos/audio/cras_audio_han...
File chromeos/audio/cras_audio_handler.cc (right):

https://codereview.chromium.org/23620055/diff/1/chromeos/audio/cras_audio_han...
chromeos/audio/cras_audio_handler.cc:34: return a.id == b.id && a.is_input ==
b.is_input && a.type == b.type
On 2013/09/16 22:38:11, Rahul Chaturvedi wrote:
> Shouldn't just comparing the id's be enough? IIRC, the device ID we get up to
> Chrome is an OR of (device_id << 32 | node_id), which should make it unique?

I am being extra careful here, after observing cras may behave unexpectedly in
some cases. This should not happen, but I am guarding it carefully just in case.

[rkc, 2013-09-16 22:56:23]

lgtm

[commit-bot: I haz the power, 2013-09-16 23:02:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennyz@chromium.org/23620055/1

[commit-bot: I haz the power, 2013-09-17 01:46:06]

Change committed as 223507