Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 23620032: PPAPI: Make API changes w/o IDL changes Warnings if generators have changed (Closed)

Created:
7 years, 3 months ago by dmichael (off chromium)
Modified:
7 years, 3 months ago
Reviewers:
teravest
CC:
chromium-reviews, DaleCurtis
Visibility:
Public.

Description

PPAPI: Make API changes w/o IDL changes Warnings if generators have changed We frequently run in to the situation where we change the generators which causes some real (but usually minor) change in header files, even though the IDL is unchanged. We should just warn in that situation, so that developers can use the CQ for these kind of generator changes. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222190

Patch Set 1 #

Patch Set 2 : Tested locally... seems to work now. #

Patch Set 3 : Oops, remove change to generator.py that was only for testing. #

Patch Set 4 : Remove debug print() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M ppapi/PRESUBMIT.py View 1 2 3 3 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dmichael (off chromium)
This problem came up again in https://codereview.chromium.org/23569005/
7 years, 3 months ago (2013-09-09 22:37:17 UTC) #1
teravest
lgtm Thanks. This had been an annoyance for me too.
7 years, 3 months ago (2013-09-09 22:40:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/23620032/4001
7 years, 3 months ago (2013-09-09 23:50:42 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 02:31:53 UTC) #4
Message was sent while issue was closed.
Change committed as 222190

Powered by Google App Engine
This is Rietveld 408576698