Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 23620020: Don't wait to notify client of spoof attempt if a modal dialog is created. (Closed)

Created:
7 years, 3 months ago by Charlie Reis
Modified:
7 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, Nate Chapin, eae+blinkwatch, gavinp+loader_chromium.org, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Don't wait to notify client of spoof attempt if a modal dialog is created. BUG=281256 TEST=See bug for repro steps. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157196

Patch Set 1 #

Total comments: 6

Patch Set 2 : Apply most of feedback #

Patch Set 3 : Use PageGroupLoadDeferrer instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1 line) Patch
M Source/core/loader/FrameLoader.h View 1 2 chunks +9 lines, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/page/PageGroupLoadDeferrer.cpp View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Charlie Reis
Darin, is this what you were picturing, rather than doing it in the browser process ...
7 years, 3 months ago (2013-09-03 21:57:26 UTC) #1
darin (slow to review)
https://codereview.chromium.org/23620020/diff/1/Source/core/loader/FrameLoader.h File Source/core/loader/FrameLoader.h (right): https://codereview.chromium.org/23620020/diff/1/Source/core/loader/FrameLoader.h#newcode118 Source/core/loader/FrameLoader.h:118: void didAccessInitialDocumentTimerFired(Timer<FrameLoader>*); I wonder... should this second method really ...
7 years, 3 months ago (2013-09-03 23:21:44 UTC) #2
Charlie Reis
Yeah, I'm worried about the other cases this might be missing, but I haven't found ...
7 years, 3 months ago (2013-09-04 00:01:10 UTC) #3
abarth-chromium
This seems difficult to maintain. If we add another program point that needs this call, ...
7 years, 3 months ago (2013-09-04 00:44:41 UTC) #4
darin (slow to review)
I think there is a point in Blink where we can trap these. I just ...
7 years, 3 months ago (2013-09-04 00:47:20 UTC) #5
Charlie Reis
On 2013/09/04 00:44:41, abarth wrote: > This seems difficult to maintain. If we add another ...
7 years, 3 months ago (2013-09-04 00:48:23 UTC) #6
abarth-chromium
I would try what Darin suggests and investigate the pathway for notifying ActiveDOMObject to suspend.
7 years, 3 months ago (2013-09-04 00:49:52 UTC) #7
darin (slow to review)
Maybe when a PageGroupLoadDeferrer (poorly named) gets created? https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/page/PageGroupLoadDeferrer.cpp&q=suspendScheduledTasks&sq=package:chromium&type=cs&l=48 On Tue, Sep 3, 2013 at ...
7 years, 3 months ago (2013-09-04 00:50:12 UTC) #8
darin (slow to review)
If you hooked PageGroupLoadDeferrer, the right thing would happen when WebView::willEnterModalLoop() gets called too. (This ...
7 years, 3 months ago (2013-09-04 00:50:53 UTC) #9
Charlie Reis
Ah, so that's what PageGroupLoadDeferrer is! Thanks, that's much better. PTAL.
7 years, 3 months ago (2013-09-04 01:06:36 UTC) #10
darin (slow to review)
LGTM (but should get Adam's review too)
7 years, 3 months ago (2013-09-04 01:09:43 UTC) #11
abarth-chromium
LGTM. Thanks! This is much better.
7 years, 3 months ago (2013-09-04 02:04:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/23620020/11005
7 years, 3 months ago (2013-09-04 02:07:58 UTC) #13
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 05:01:11 UTC) #14
Message was sent while issue was closed.
Change committed as 157196

Powered by Google App Engine
This is Rietveld 408576698