Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 23619061: remove unnecessary Shell::Initialize causing DCHECK on gpu_win bots (Closed)

Created:
7 years, 3 months ago by scottmg
Modified:
7 years, 3 months ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, jam, apatrick_chromium, darin-cc_chromium.org, alokp
Visibility:
Public.

Description

remove unnecessary Shell::Initialize causing DCHECK on gpu_win bots It's already called in ShellBrowserMainParts::PreMainMessageLoopRun which happens earlier. R=piman@chromium.org BUG=292874 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223553

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/browser/gpu/gpu_functional_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
7 years, 3 months ago (2013-09-17 01:16:40 UTC) #1
piman
lgtm
7 years, 3 months ago (2013-09-17 03:12:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/23619061/1
7 years, 3 months ago (2013-09-17 03:26:32 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 06:47:52 UTC) #4
Message was sent while issue was closed.
Change committed as 223553

Powered by Google App Engine
This is Rietveld 408576698