Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 23619025: Fix use after free when handling async touch events (Closed)

Created:
7 years, 3 months ago by sky
Modified:
7 years, 3 months ago
Reviewers:
ananta
CC:
chromium-reviews, tfarina, ben+watch_chromium.org
Visibility:
Public.

Description

Fix use after free when handling async touch events It's possible for the NativeView (aura::RootWindow*) in this case to be destroyed by the time we end up processing the events. BUG=288086 TEST=none R=ananta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222167

Patch Set 1 #

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M ui/views/widget/desktop_aura/desktop_root_window_host_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.cc View 1 1 chunk +7 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/win/hwnd_message_handler_delegate.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
7 years, 3 months ago (2013-09-09 20:12:13 UTC) #1
ananta
lgtm
7 years, 3 months ago (2013-09-09 22:24:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/23619025/3001
7 years, 3 months ago (2013-09-09 22:30:55 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 01:16:06 UTC) #4
Message was sent while issue was closed.
Change committed as 222167

Powered by Google App Engine
This is Rietveld 408576698