Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 23619024: [Android WebView] Enable spatial navigation / DPAD (Closed)

Created:
7 years, 3 months ago by joth
Modified:
7 years, 3 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

[Android WebView] Enable spatial navigation / DPAD Turn on the --enable-spatial-navigation flag, and also bubble up unhandled DPAD events to the neighboring views in the view tree. Likewise, WebContentsDelegate::TakeFocus() bubble to logical next or previous neighbor view. Also disabled the FileSystem API while in the area updating flags. BUG=286698 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221946

Patch Set 1 #

Patch Set 2 : takeFocus #

Patch Set 3 : fix #

Total comments: 1

Patch Set 4 : switches #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -2 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java View 1 2 3 chunks +41 lines, -1 line 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
joth
7 years, 3 months ago (2013-09-07 04:17:39 UTC) #1
boliu
lgtm
7 years, 3 months ago (2013-09-07 04:21:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/23619024/7001
7 years, 3 months ago (2013-09-07 04:53:54 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-07 05:27:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/23619024/7001
7 years, 3 months ago (2013-09-07 17:31:35 UTC) #5
boliu
https://chromiumcodereview.appspot.com/23619024/diff/7001/android_webview/lib/main/aw_main_delegate.cc File android_webview/lib/main/aw_main_delegate.cc (right): https://chromiumcodereview.appspot.com/23619024/diff/7001/android_webview/lib/main/aw_main_delegate.cc#newcode68 android_webview/lib/main/aw_main_delegate.cc:68: cl->AppendSwitch(switches::kDisableFileSystem); Don't think that was a flake, need to ...
7 years, 3 months ago (2013-09-07 17:37:18 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-07 17:49:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/23619024/34001
7 years, 3 months ago (2013-09-07 22:04:36 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-08 03:38:33 UTC) #9
Message was sent while issue was closed.
Change committed as 221946

Powered by Google App Engine
This is Rietveld 408576698