keep_test_server_ports to BrowserOptions.

keep_test_server_ports to BrowserOptions (this should probably go into AndroidBrowserOptions). android_rndis is a new ctor arg to AndroidBrowserBackend.

BUG=269131
TEST=trybot

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222145

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222308

[achuithb, 2013-09-07 00:25:15]

Please take a look, Tony.

[tonyg, 2013-09-07 01:00:40]

lgtm

[achuithb, 2013-09-07 17:15:53]

On 2013/09/07 01:00:40, tonyg wrote:
> lgtm

ty!

[commit-bot: I haz the power, 2013-09-07 17:29:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/23619022/6001

[commit-bot: I haz the power, 2013-09-07 17:40:52]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

[commit-bot: I haz the power, 2013-09-07 17:46:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/23619022/6001

[commit-bot: I haz the power, 2013-09-07 19:05:26]

Retried try job too often on mac_rel for step(s) telemetry_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[achuithb, 2013-09-08 20:04:34]

Tony - I didn't realize that android_rndis was being used by
FindAllAvailableBrowsers:
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...

I'm now passing it in as a ctor argument to AndroidBrowserBackend. Please take
another look.

[tonyg, 2013-09-08 23:48:53]

lgtm

[commit-bot: I haz the power, 2013-09-09 20:03:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/23619022/33001

[commit-bot: I haz the power, 2013-09-10 00:11:22]

Change committed as 222145

[please use gerrit instead, 2013-09-10 03:08:24]

On 2013/09/10 00:11:22, I haz the power (commit-bot) wrote:
> Change committed as 222145

This change appears to have broken PageMeasurementUnitTest.testGotQueryParams on
Mac10.7 Tests (3) bot. Build number 18529.


PageMeasurementUnitTest.testGotQueryParams: 
Traceback (most recent call last):
File
"/Volumes/data/b/build/slave/Mac10_7_Tests__3_/build/src/tools/telemetry/telemetry/page/page_measurement_unittest.py",
line 70, in testGotQueryParams
all_results = self.RunMeasurement(measurement, ps, options=self._options)
File
"/Volumes/data/b/build/slave/Mac10_7_Tests__3_/build/src/tools/telemetry/telemetry/page/page_measurement_unittest_base.py",
line 48, in RunMeasurement
return page_runner.Run(measurement, ps, expectations, options)
File
"/Volumes/data/b/build/slave/Mac10_7_Tests__3_/build/src/tools/telemetry/telemetry/page/page_runner.py",
line 286, in Run
possible_browser, results, state)
File
"/Volumes/data/b/build/slave/Mac10_7_Tests__3_/build/src/tools/telemetry/telemetry/page/page_runner.py",
line 192, in _PrepareAndRunPage
results_for_current_run, finder_options)
File
"/Volumes/data/b/build/slave/Mac10_7_Tests__3_/build/src/tools/telemetry/telemetry/page/page_runner.py",
line 395, in _RunPage
test.Run(finder_options, page, tab, results)
File
"/Volumes/data/b/build/slave/Mac10_7_Tests__3_/build/src/tools/telemetry/telemetry/page/page_test.py",
line 176, in Run
self._test_method(page, tab, results)
File
"/Volumes/data/b/build/slave/Mac10_7_Tests__3_/build/src/tools/telemetry/telemetry/page/page_measurement.py",
line 54, in _RunTest
self.MeasurePage(page, tab, results)
File
"/Volumes/data/b/build/slave/Mac10_7_Tests__3_/build/src/tools/telemetry/telemetry/page/page_measurement_unittest.py",
line 44, in MeasurePage
assert query.strip() == '?foo=1'
AssertionError

[achuithb, 2013-09-10 06:52:27]

On 2013/09/10 03:08:24, Rouslan Solomakhin wrote:
> On 2013/09/10 00:11:22, I haz the power (commit-bot) wrote:
> > Change committed as 222145
> 
> This change appears to have broken PageMeasurementUnitTest.testGotQueryParams
on
> Mac10.7 Tests (3) bot. Build number 18529.
> 
> 
> PageMeasurementUnitTest.testGotQueryParams: 
> Traceback (most recent call last):
> File
>
"/Volumes/data/b/build/slave/Mac10_7_Tests__3_/build/src/tools/telemetry/telemetry/page/page_measurement_unittest.py",
> line 70, in testGotQueryParams
> all_results = self.RunMeasurement(measurement, ps, options=self._options)
> File
>
"/Volumes/data/b/build/slave/Mac10_7_Tests__3_/build/src/tools/telemetry/telemetry/page/page_measurement_unittest_base.py",
> line 48, in RunMeasurement
> return page_runner.Run(measurement, ps, expectations, options)
> File
>
"/Volumes/data/b/build/slave/Mac10_7_Tests__3_/build/src/tools/telemetry/telemetry/page/page_runner.py",
> line 286, in Run
> possible_browser, results, state)
> File
>
"/Volumes/data/b/build/slave/Mac10_7_Tests__3_/build/src/tools/telemetry/telemetry/page/page_runner.py",
> line 192, in _PrepareAndRunPage
> results_for_current_run, finder_options)
> File
>
"/Volumes/data/b/build/slave/Mac10_7_Tests__3_/build/src/tools/telemetry/telemetry/page/page_runner.py",
> line 395, in _RunPage
> test.Run(finder_options, page, tab, results)
> File
>
"/Volumes/data/b/build/slave/Mac10_7_Tests__3_/build/src/tools/telemetry/telemetry/page/page_test.py",
> line 176, in Run
> self._test_method(page, tab, results)
> File
>
"/Volumes/data/b/build/slave/Mac10_7_Tests__3_/build/src/tools/telemetry/telemetry/page/page_measurement.py",
> line 54, in _RunTest
> self.MeasurePage(page, tab, results)
> File
>
"/Volumes/data/b/build/slave/Mac10_7_Tests__3_/build/src/tools/telemetry/telemetry/page/page_measurement_unittest.py",
> line 44, in MeasurePage
> assert query.strip() == '?foo=1'
> AssertionError

I don't see how this change could've caused the failure?

[commit-bot: I haz the power, 2013-09-10 11:53:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/23619022/56001

[commit-bot: I haz the power, 2013-09-10 14:21:08]

Retried try job too often on win_rel for step(s) chrome_frame_net_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-09-10 16:09:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/23619022/56001

[commit-bot: I haz the power, 2013-09-10 18:11:17]

Change committed as 222308