Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 23619019: Set position: absolute on NTP thumbnails (Closed)

Created:
7 years, 3 months ago by Mathieu
Modified:
7 years, 3 months ago
Reviewers:
Jered
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, mad+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org
Visibility:
Public.

Description

Set position: absolute on NTP thumbnails This fixes a bug where, when using two thumbnails in the same iframe, they would be reordered if their visibility changed. This would only happen on the second and further NTPs, perhaps on relayout by Chrome. This changes it so that they are superposed, which is how it should have been all along. Putting position: absolute will make both anchor on body. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221789

Patch Set 1 #

Patch Set 2 : Changed comment wording #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/resources/local_ntp/most_visited_thumbnail.js View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mathieu
Hi Jered, PTAL. This should have no effect on situations where there is only one ...
7 years, 3 months ago (2013-09-06 15:30:07 UTC) #1
Jered
On 2013/09/06 15:30:07, Mathieu Perreault wrote: > Hi Jered, PTAL. > > This should have ...
7 years, 3 months ago (2013-09-06 18:56:11 UTC) #2
Mathieu
On 2013/09/06 18:56:11, Jered wrote: > On 2013/09/06 15:30:07, Mathieu Perreault wrote: > > Hi ...
7 years, 3 months ago (2013-09-06 18:58:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mathp@chromium.org/23619019/1002
7 years, 3 months ago (2013-09-06 18:58:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mathp@chromium.org/23619019/1002
7 years, 3 months ago (2013-09-06 20:47:38 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 21:47:11 UTC) #6
Message was sent while issue was closed.
Change committed as 221789

Powered by Google App Engine
This is Rietveld 408576698