Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 23619012: cc: Adopt new skia object when it's created to avoid memory leak. (Closed)

Created:
7 years, 3 months ago by danakj
Modified:
7 years, 3 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, reed1, Stephen White, earthdok
Visibility:
Public.

Description

cc: Adopt new skia object when it's created to avoid memory leak. Skia ref-counted objects must always be adopted at creation time in order to prevent memory leaks. The SoftwareRenderer was creating an SkDrawFilter and passing it to the SkCanvas without adopting it first, and this was leaking the filter. R=aelias BUG=285161 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M cc/output/software_renderer.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
danakj
7 years, 3 months ago (2013-09-04 14:27:39 UTC) #1
danakj
+earthdok
7 years, 3 months ago (2013-09-04 14:27:58 UTC) #2
tomhudson
Dag-nabbit, I missed that in the review. :(
7 years, 3 months ago (2013-09-04 14:35:30 UTC) #3
enne (OOO)
lgtm
7 years, 3 months ago (2013-09-04 17:46:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/23619012/1
7 years, 3 months ago (2013-09-04 17:47:09 UTC) #5
commit-bot: I haz the power
Change committed as 221247
7 years, 3 months ago (2013-09-04 20:11:56 UTC) #6
aelias_OOO_until_Jul13
7 years, 3 months ago (2013-09-04 20:54:33 UTC) #7
Message was sent while issue was closed.
Thanks.  Classic WebView did the same thing so I assumed the refcounts somehow
worked out there :/

Powered by Google App Engine
This is Rietveld 408576698