Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 23618042: [telemetry] Add new benchmarks and rename them all. (Closed)

Created:
7 years, 3 months ago by dtu
Modified:
7 years, 3 months ago
Reviewers:
tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[telemetry] Add new benchmarks and rename them all. BUG=None. TEST=./run_benchmark list Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222736

Patch Set 1 #

Total comments: 4

Patch Set 2 : Convenience features for our fingers. #

Patch Set 3 : Add tab switching and flag to netsim. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -42 lines) Patch
M tools/perf/benchmarks/blink_perf.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/page_cycler.py View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/startup.py View 1 2 chunks +2 lines, -0 lines 0 comments Download
A + tools/perf/benchmarks/tab_switching.py View 1 2 1 chunk +6 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/test.py View 1 1 chunk +9 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/test_runner.py View 1 5 chunks +85 lines, -36 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dtu
The full list of benchmarks is (not including measurements): Available tests are: blink_perf dom_perf A ...
7 years, 3 months ago (2013-09-11 01:44:58 UTC) #1
tonyg
Just two question, else lg https://codereview.chromium.org/23618042/diff/1/tools/perf/benchmarks/startup.py File tools/perf/benchmarks/startup.py (right): https://codereview.chromium.org/23618042/diff/1/tools/perf/benchmarks/startup.py#newcode10 tools/perf/benchmarks/startup.py:10: name = 'cold' We ...
7 years, 3 months ago (2013-09-11 02:04:05 UTC) #2
dtu
PTAL I added some string matching to the tests. If you do "./run_benchmark domcorea", it'll ...
7 years, 3 months ago (2013-09-12 00:12:58 UTC) #3
tonyg
lgtm
7 years, 3 months ago (2013-09-12 01:04:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/23618042/11001
7 years, 3 months ago (2013-09-12 01:20:51 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-12 06:28:36 UTC) #6
Message was sent while issue was closed.
Change committed as 222736

Powered by Google App Engine
This is Rietveld 408576698