[Files.app] Refile a timing of doing selectBestMatchItem().

[Files.app] Refile a timing of doing selectBestMatchItem().

Previously, selectBestMatchItem() is called in the 'permuted'/'changed' handlers of the data model. But in this timing, although we can make sure that the data model is updated, but the list elements in the list may not be updated (it depends on the order of registration of event listeners). Then we can't select the target item since the target item may not be created yet.

This patch delays it just after the updating of elements in list.

BUG=280155
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221246

[yoshiki, 2013-09-03 07:50:19]

@hirono, could you take a look? Thanks.

[hirono, 2013-09-03 08:20:30]

https://codereview.chromium.org/23618028/diff/3001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/navigation_list.js (right):

https://codereview.chromium.org/23618028/diff/3001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/navigation_list.js:687:
NavigationList.prototype.endBatchUpdates = function() {
It seems that the endBatchUpdates will not be called when the dataModel#change
event triggered. Is it OK?

[yoshiki, 2013-09-03 09:33:32]

@hirono, PTAL.

https://codereview.chromium.org/23618028/diff/3001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/navigation_list.js (right):

https://codereview.chromium.org/23618028/diff/3001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/navigation_list.js:687:
NavigationList.prototype.endBatchUpdates = function() {
On 2013/09/03 08:20:30, hirono wrote:
> It seems that the endBatchUpdates will not be called when the dataModel#change
> event triggered. Is it OK?

Good catch. Fixed.

[hirono, 2013-09-03 09:47:21]

https://codereview.chromium.org/23618028/diff/12001/chrome/browser/resources/...
File chrome/browser/resources/file_manager/js/navigation_list.js (right):

https://codereview.chromium.org/23618028/diff/12001/chrome/browser/resources/...
chrome/browser/resources/file_manager/js/navigation_list.js:690:
this.onListContentChanged_();
It seems that the redraw event is raised at the scroll event.
Does calling onListContentChanged_ for all the scroll event look heavy?

[yoshiki, 2013-09-04 13:21:11]

@hirono: PTAL. Thanks.

https://codereview.chromium.org/23618028/diff/12001/chrome/browser/resources/...
File chrome/browser/resources/file_manager/js/navigation_list.js (right):

https://codereview.chromium.org/23618028/diff/12001/chrome/browser/resources/...
chrome/browser/resources/file_manager/js/navigation_list.js:690:
this.onListContentChanged_();
On 2013/09/03 09:47:21, hirono wrote:
> It seems that the redraw event is raised at the scroll event.
> Does calling onListContentChanged_ for all the scroll event look heavy?

Thanks for good catching. I've found it can be fixed by changing the order of
registering handlers.

[hirono, 2013-09-04 13:39:25]

lgtm with nit!

https://codereview.chromium.org/23618028/diff/16001/chrome/browser/resources/...
File chrome/browser/resources/file_manager/js/navigation_list.js (right):

https://codereview.chromium.org/23618028/diff/16001/chrome/browser/resources/...
chrome/browser/resources/file_manager/js/navigation_list.js:454: 'change',
this.boundHandleListChanged_);
nit: The name pattern of xxxBound is more likely to use in Files.app.

https://code.google.com/p/chromium/codesearch#search/&q=on%5Ba-zA-Z%5D%2BBoun...

[hirono, 2013-09-04 13:42:12]

Sorry the search queries are:

on[a-zA-Z]+Bound file:\.js$
bound[a-zA-Z]+ file:file_manager\/.+\.js$

[yoshiki, 2013-09-04 14:26:55]

Thanks.

https://codereview.chromium.org/23618028/diff/16001/chrome/browser/resources/...
File chrome/browser/resources/file_manager/js/navigation_list.js (right):

https://codereview.chromium.org/23618028/diff/16001/chrome/browser/resources/...
chrome/browser/resources/file_manager/js/navigation_list.js:454: 'change',
this.boundHandleListChanged_);
On 2013/09/04 13:39:25, hirono wrote:
> nit: The name pattern of xxxBound is more likely to use in Files.app.
> 
>
https://code.google.com/p/chromium/codesearch#search/&q=on%255Ba-zA-Z%255D%25...

Done.

[commit-bot: I haz the power, 2013-09-04 16:36:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/23618028/22001

[commit-bot: I haz the power, 2013-09-04 20:11:31]

Change committed as 221246