Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 23618015: Add GetMatchingOutputDeviceID to CoreAudioUtil. (Closed)

Created:
7 years, 3 months ago by tommi (sloooow) - chröme
Modified:
7 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add GetMatchingOutputDeviceID to CoreAudioUtil. This method accepts an ID of an input device and finds an output device belonging to the same hardware (if one exists) and returns its ID. BUG=276894 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220566

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -1 line) Patch
M media/audio/win/core_audio_util_win.h View 1 chunk +6 lines, -0 lines 0 comments Download
M media/audio/win/core_audio_util_win.cc View 1 1 chunk +42 lines, -0 lines 0 comments Download
M media/audio/win/core_audio_util_win_unittest.cc View 2 chunks +35 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tommi (sloooow) - chröme
7 years, 3 months ago (2013-08-30 08:38:32 UTC) #1
henrika (OOO until Aug 14)
Nice. LGTM. https://codereview.chromium.org/23618015/diff/1/media/audio/win/core_audio_util_win.cc File media/audio/win/core_audio_util_win.cc (right): https://codereview.chromium.org/23618015/diff/1/media/audio/win/core_audio_util_win.cc#newcode397 media/audio/win/core_audio_util_win.cc:397: output_device = NULL; Is this needed? https://codereview.chromium.org/23618015/diff/1/media/audio/win/core_audio_util_win.cc#newcode401 ...
7 years, 3 months ago (2013-08-30 09:45:40 UTC) #2
tommi (sloooow) - chröme
https://codereview.chromium.org/23618015/diff/1/media/audio/win/core_audio_util_win.cc File media/audio/win/core_audio_util_win.cc (right): https://codereview.chromium.org/23618015/diff/1/media/audio/win/core_audio_util_win.cc#newcode397 media/audio/win/core_audio_util_win.cc:397: output_device = NULL; On 2013/08/30 09:45:40, henrika wrote: > ...
7 years, 3 months ago (2013-08-30 10:45:34 UTC) #3
tommi (sloooow) - chröme
address comments
7 years, 3 months ago (2013-08-30 10:45:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/23618015/7001
7 years, 3 months ago (2013-08-30 10:46:07 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 12:40:15 UTC) #6
Message was sent while issue was closed.
Change committed as 220566

Powered by Google App Engine
This is Rietveld 408576698