Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 23617006: WebCrypto: Add the KeyPair interface. (Closed)

Created:
7 years, 3 months ago by eroman
Modified:
7 years, 3 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, eae+blinkwatch, tommyw+watchlist_chromium.org, dglazkov+blink, jeez
Visibility:
Public.

Description

Patch Set 1 : #

Patch Set 2 : Add test for expando property not being gc-ed #

Patch Set 3 : rebase onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -25 lines) Patch
M LayoutTests/crypto/generateKey.html View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
M LayoutTests/crypto/generateKey-expected.txt View 1 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/platform/chromium/support/WebCrypto.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download
M Source/modules/crypto/CryptoResult.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/crypto/CryptoResult.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
A + Source/modules/crypto/KeyPair.h View 1 chunk +14 lines, -11 lines 0 comments Download
A + Source/modules/crypto/KeyPair.cpp View 1 chunk +12 lines, -11 lines 0 comments Download
A + Source/modules/crypto/KeyPair.idl View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M Source/modules/modules.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/testing/runner/MockWebCrypto.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M public/platform/WebCrypto.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
eroman
7 years, 3 months ago (2013-08-27 21:47:00 UTC) #1
abarth-chromium
LGTM Can you add a test that KeyPair correct retains the JS wrappers for the ...
7 years, 3 months ago (2013-08-27 23:43:24 UTC) #2
eroman
Done (I believe I have added the requested test) When you get a chance please ...
7 years, 3 months ago (2013-08-28 00:02:05 UTC) #3
abarth-chromium
On 2013/08/28 00:02:05, eroman wrote: > Done (I believe I have added the requested test) ...
7 years, 3 months ago (2013-08-28 00:08:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/23617006/2001
7 years, 3 months ago (2013-08-28 03:46:08 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-08-28 06:36:21 UTC) #6
Message was sent while issue was closed.
Change committed as 156824

Powered by Google App Engine
This is Rietveld 408576698