Issue 23615013: Completes crrev.com/23478020 and makes sure of detachment from IME.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23615013: Completes crrev.com/23478020 and makes sure of detachment from IME. (Closed)

Created:
7 years, 3 months ago by Yuki

Modified:
7 years, 3 months ago

Reviewers:
yukawa, Seigo Nonaka

CC:
chromium-reviews, nona+watch_chromium.org, James Su, tfarina, penghuang+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Completes crrev.com/23478020 and makes sure of detachment from IME. http://crrev.com/23478020 was incomplete and this CL implements the rest. BUG=280219 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221748

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -3 lines)			Patch
M	ui/base/ime/input_method_tsf.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/base/ime/input_method_tsf.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ui/base/ime/win/tsf_bridge.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/ime/input_method_bridge.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Yuki

Could you review this CL? I'll commit this CL after we confirm the fix by ...

7 years, 3 months ago (2013-09-06 13:04:59 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/23615013/1

7 years, 3 months ago (2013-09-06 13:29:41 UTC) #3

Message was sent while issue was closed.

Change committed as 221748