Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 23614016: [Activity Log] Enable end to end tests on windows. (Closed)

Created:
7 years, 3 months ago by karenlees
Modified:
7 years, 3 months ago
Reviewers:
felt
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, felt, extensions-reviews_chromium.org
Visibility:
Public.

Description

[Activity Log] Enable end to end tests on windows. Enables most of the test cases on windows. Adds TODOs and bug numbers for those still disabled. BUG=245594 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223460

Patch Set 1 #

Patch Set 2 : Fix expected logging for incognito test #

Patch Set 3 : Merge with chromeos enable #

Patch Set 4 : Merge with change to enable on mac #

Patch Set 5 : Fix line >80 chars in readme file #

Patch Set 6 : Add TODOs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -10 lines) Patch
M chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc View 1 2 3 1 chunk +1 line, -8 lines 0 comments Download
M chrome/test/data/extensions/api_test/activity_log_private/README View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/activity_log_private/test/test.js View 1 2 3 4 5 8 chunks +39 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
karenlees
7 years, 3 months ago (2013-09-16 19:52:50 UTC) #1
felt
lgtm, with one nit: can you put "TODO" statements on the comments with bugs? Just ...
7 years, 3 months ago (2013-09-16 19:55:33 UTC) #2
karenlees
On 2013/09/16 19:55:33, felt wrote: > lgtm, with one nit: can you put "TODO" statements ...
7 years, 3 months ago (2013-09-16 20:00:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/karenlees@chromium.org/23614016/16001
7 years, 3 months ago (2013-09-16 20:13:12 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 23:08:57 UTC) #5
Message was sent while issue was closed.
Change committed as 223460

Powered by Google App Engine
This is Rietveld 408576698