Issue 23614007: Use the normal Google logo for managed users for --enable-instant-extended-api

Issue 23614007: Use the normal Google logo for managed users for --enable-instant-extended-api (Closed)

Created:
7 years, 3 months ago by pkotwicz

Modified:
7 years, 3 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, asanka, dbeam+watch-ntp_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, estade+watch_chromium.org, benjhayden+dwatch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, mad+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, tfarina, kmadhusu+watch_chromium.org, Jered, pedrosimonetti+watch_chromium.org, Adrian Kuegel

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

This CL makes managed users use the normal Google logo on the --enable-instant-extended-api NTP. I also changed the signature of ui::ThemeProvider::GetDisplayProperty() because most of the callers were ignoring the return value. In some cases we were using uninitialized variables because of this. BUG=279978 TEST=Manual, see bug R=erg TBR=sky (For trivial refactor) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220537

Patch Set 1 : #

Patch Set 2 : Fixed mac compile failure #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -64 lines)			Patch
M	chrome/browser/search/instant_service.cc	View		2 chunks	+7 lines, -12 lines	0 comments	Download
M	chrome/browser/themes/theme_properties.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/themes/theme_properties.cc	View		2 chunks	+8 lines, -10 lines	0 comments	Download
M	chrome/browser/themes/theme_service.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/themes/theme_service.cc	View		3 chunks	+17 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/download/background_theme.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/download/background_theme.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/ntp_background_util.cc	View		1 chunk	+7 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_desktop_root_window_host_win.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/ntp_resource_cache.cc	View		4 chunks	+7 lines, -10 lines	0 comments	Download
M	ui/base/default_theme_provider.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/default_theme_provider.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/base/theme_provider.h	View		1 chunk	+1 line, -1 line	0 comments	Download