A buildstep has been renamed, this is causing the Skia Commit Queue to fail.

A buildstep has been renamed this is causing the Skia Commit Queue to fail.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=219802

[rmistry, 2013-08-27 16:22:11]

https://codereview.chromium.org/23612002/diff/1/projects.py
File projects.py (right):

https://codereview.chromium.org/23612002/diff/1/projects.py#newcode515
projects.py:515: # compile_required_build_steps = json.load(
Commenting this out because changing this on Skia's master requires a restart
which we do not want to do in the middle of the day.

[cmp, 2013-08-27 16:28:51]

lgtm

[agable, 2013-08-27 16:33:36]

https://codereview.chromium.org/23612002/diff/1/projects.py
File projects.py (right):

https://codereview.chromium.org/23612002/diff/1/projects.py#newcode515
projects.py:515: # compile_required_build_steps = json.load(
On 2013/08/27 16:22:11, rmistry wrote:
> Commenting this out because changing this on Skia's master requires a restart
> which we do not want to do in the middle of the day.

This is broken because the urlopen is hanging? Sitting on the cq machine, I
can't get that url to load. Is this because of an error on the try_server_url
machine, or an error in that url itself? If the latter, it seems like it would
be better to fix line 504.

[rmistry, 2013-08-27 16:40:17]

https://codereview.chromium.org/23612002/diff/1/projects.py
File projects.py (right):

https://codereview.chromium.org/23612002/diff/1/projects.py#newcode515
projects.py:515: # compile_required_build_steps = json.load(
On 2013/08/27 16:33:36, Aaron Gable wrote:
> On 2013/08/27 16:22:11, rmistry wrote:
> > Commenting this out because changing this on Skia's master requires a
restart
> > which we do not want to do in the middle of the day.
> 
> This is broken because the urlopen is hanging? Sitting on the cq machine, I
> can't get that url to load. Is this because of an error on the try_server_url
> machine, or an error in that url itself? If the latter, it seems like it would
> be better to fix line 504.

This is because the steps returned at that url are incorrect (BuildMost should
be BuildEverything), we can fix it with a master restart but since it is the
middle of the day we do not want to restart the master.

The url should be working:
http://173.255.115.253:10117/json/cq_required_steps?as_text=1
Do you see it not working?

[commit-bot: I haz the power, 2013-08-27 16:40:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rmistry@google.com/23612002/1

[commit-bot: I haz the power, 2013-08-27 16:40:44]

Change committed as 219802

[agable, 2013-08-27 16:42:56]

https://codereview.chromium.org/23612002/diff/1/projects.py
File projects.py (right):

https://codereview.chromium.org/23612002/diff/1/projects.py#newcode515
projects.py:515: # compile_required_build_steps = json.load(
On 2013/08/27 16:40:18, rmistry wrote:
> On 2013/08/27 16:33:36, Aaron Gable wrote:
> > On 2013/08/27 16:22:11, rmistry wrote:
> > > Commenting this out because changing this on Skia's master requires a
> restart
> > > which we do not want to do in the middle of the day.
> > 
> > This is broken because the urlopen is hanging? Sitting on the cq machine, I
> > can't get that url to load. Is this because of an error on the
try_server_url
> > machine, or an error in that url itself? If the latter, it seems like it
would
> > be better to fix line 504.
> 
> This is because the steps returned at that url are incorrect (BuildMost should
> be BuildEverything), we can fix it with a master restart but since it is the
> middle of the day we do not want to restart the master.
> 
> The url should be working:
> http://173.255.115.253:10117/json/cq_required_steps?as_text=1
> Do you see it not working?

It was hanging and timing out for me. Now it works. Dunno what was going on.

I'll go ahead and restart your CQ now.