Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 23611006: Fix incorrect manifest JSON in the chrome.downloads intro. (Closed)

Created:
7 years, 3 months ago by epeterson
Modified:
7 years, 3 months ago
Reviewers:
Andy, evan.peterson.ep, not at google - send to devlin
CC:
agautam1, chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix incorrect manifest JSON in the chrome.downloads intro. Also add a little extra flair. BUG=278904 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221458

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/common/extensions/docs/templates/intros/downloads.html View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
epeterson
Hey there, Saw that this issue hadn't been touched in a while and didn't want ...
7 years, 3 months ago (2013-09-04 21:55:43 UTC) #1
Andy
lgtm
7 years, 3 months ago (2013-09-05 01:19:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/evan.peterson.EP@gmail.com/23611006/1
7 years, 3 months ago (2013-09-05 16:16:20 UTC) #3
commit-bot: I haz the power
Change committed as 221458
7 years, 3 months ago (2013-09-05 18:10:38 UTC) #4
not at google - send to devlin
7 years, 3 months ago (2013-09-05 19:27:47 UTC) #5
Message was sent while issue was closed.
Thanks Evan!

Powered by Google App Engine
This is Rietveld 408576698